Skip to content

Conversation

@trembel
Copy link
Contributor

@trembel trembel commented Jun 19, 2024

This commit adds functionality to the Receiver type in order to estimate the Carrier Frequency Offset between a sender and a receiver according to DW3000 User Manual, Chapter 8.2.7.6.

@trembel trembel marked this pull request as draft June 20, 2024 12:07
@trembel trembel force-pushed the carrier-freq-offset branch 2 times, most recently from c80df5e to 99aef80 Compare June 24, 2024 07:50
This commit adds functionality to the Receiver type in order to
estimate the Carrier Frequency Offset between a sender and a receiver
according to DW3000 User Manual, Chapter 8.2.7.6.

Signed-off-by: Silvano Cortesi <[email protected]>

[ADD] Carrier Frequency Offset to returned message(s)

Signed-off-by: Silvano Cortesi <[email protected]>
@trembel trembel force-pushed the carrier-freq-offset branch from 99aef80 to 55960f0 Compare June 24, 2024 07:52
@trembel trembel marked this pull request as ready for review June 25, 2024 07:54
@ProfFan
Copy link
Owner

ProfFan commented Jul 29, 2024

r_wait_buf is meant to be small, I wonder how this could be elegantly handled, as a lot of other functionalities share this pattern. What I am currently doing is reading this register after r_wait_buf and before enabling RX again which clears the register. Pls let me know what you think

@trembel
Copy link
Contributor Author

trembel commented Aug 19, 2024

Sorry for the late response; You think to split it out of the r_wait_... and then sequentially read it out? I'm good with this as well; however, then I think also the readout of CIR / estimation of signal quality does not belong in there (as it is also very time intense) and to some extense even the readout of rx_time.

I'm a bit struggling on which structure would make sense. IMO there would be the need of a new state - as the ready state is the wrong state to readout rx_time, cir, cfo, ... (as there might not be any message arrived before). That's why I put it into the rx_wait fct, as afterwards the state is changed.

@ProfFan
Copy link
Owner

ProfFan commented Aug 19, 2024

Note that only

rxing.finish_receiving()

will switch the type state, so you can read all these things before calling this function. One just need to be careful not to read stuff when r_wait_buf has not returned Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants