Skip to content

Conversation

dividor
Copy link

@dividor dividor commented Dec 11, 2024

  • First pass

  • CU kinda working

  • CU integration

  • Better splitting

  • Add Bicep

  • Rm unneeded figures

  • Remove en-us from URLs

  • Fix URLs

  • Remote figures output JSON

  • Update matrix comments

  • Make mypy happy

  • Add same errors to file strategy

  • Add pymupdf to skip modules for mypy

  • Output the endpoint from Bicep

  • 100 percent coverage for mediadescriber.py

  • Tests added for PDFParser

  • Fix that tuple type

  • Add pricing link

  • Fix content read issue

Purpose

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[ ] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[ ] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

…e-Samples#2195)

* First pass

* CU kinda working

* CU integration

* Better splitting

* Add Bicep

* Rm unneeded figures

* Remove en-us from URLs

* Fix URLs

* Remote figures output JSON

* Update matrix comments

* Make mypy happy

* Add same errors to file strategy

* Add pymupdf to skip modules for mypy

* Output the endpoint from Bicep

* 100 percent coverage for mediadescriber.py

* Tests added for PDFParser

* Fix that tuple type

* Add pricing link

* Fix content read issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants