story #13791: clean code #2360
Open
story #13791: clean code #2360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohatizaoui
force-pushed
the
story_13791_clean_code
branch
from
422e98c to
0d97465
Compare
mohatizaoui
force-pushed
the
story_13791_clean_code
branch
from
0d97465 to
a1476f9
Compare
hazco75
reviewed
Feb 17, 2025
Comment on lines
94
to
+96
| LOGGER.debug("get all customer criteria={}", criteria); | ||
| SanityChecker.sanitizeCriteria(criteria); | ||
| return securityProfileExternalService.getAll(criteria); | ||
| return securityProfileExternalService.getAll(); |
There was a problem hiding this comment.
A quoi sert la variable criteria si elle n'est plus appelée par getAll() ?
There was a problem hiding this comment.
D'accord avec Hassane, il faut supprimer la variable criteria.
ebernard
requested changes
Feb 17, 2025
Comment on lines
102
to
+104
| SanityChecker.sanitizeCriteria(criteria); | ||
| LOGGER.debug("get all customer criteria={}", criteria); | ||
| return agencyExternalService.getAll(criteria); | ||
| return agencyExternalService.getAll(); |
There was a problem hiding this comment.
Enlever criteria si pas utilisé.
Comment on lines
94
to
+96
| LOGGER.debug("get all customer criteria={}", criteria); | ||
| SanityChecker.sanitizeCriteria(criteria); | ||
| return securityProfileExternalService.getAll(criteria); | ||
| return securityProfileExternalService.getAll(); |
There was a problem hiding this comment.
D'accord avec Hassane, il faut supprimer la variable criteria.
|
|
||
| @Autowired | ||
| private UnitExtternalService unitExternalService; | ||
| private UnitExternalService unitExternalService; |
| throws IOException, InvalidParseOperationException { | ||
| InputStream inputStream = | ||
| AccessionRegisterInternalServiceTest.class.getClassLoader().getResourceAsStream(filename); | ||
| fr.gouv.vitamui.referential.internal.server.service |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description des modifications
Type de changement
Indiquer le ou les types de changements
Documentation
Indiquer la documentation mise à jour
Tests
Indiquer comment le code à été testé (manuel, environnement, TU, etc)
Migration
Indiquer si les modifications apportées impliquent une migration sur l'existant et comment la faire
Checklist
Sélectionner les éléments de la checklist
Contributeur
Indiquer qui a développé cette fonctionnalité