Skip to content

Bug #15468 [Profile Groups] – The “Next” button becomes clickable before the name is validated. #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Salimdev merged 1 commit into from
Dec 16, 2025
Merged

Bug #15468 [Profile Groups] – The “Next” button becomes clickable before the name is validated. #3406

Salimdev merged 1 commit into from
Dec 16, 2025

Conversation

@Salimdev
Copy link
Contributor

@Salimdev Salimdev commented Dec 1, 2025

Le bouton “Suivant” devient cliquable avant le contrôle du nom.

@Salimdev Salimdev added this to the IT 162 milestone Dec 1, 2025
@Salimdev Salimdev self-assigned this Dec 1, 2025
@Salimdev Salimdev added the bug Something isn't working label Dec 1, 2025
@vitam-prg
Copy link
Collaborator

vitam-prg commented Dec 1, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 93e9b3ea-9f2c-4b14-b191-235c38f14f3a

Fixed Issues (58)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CVE-2025-13466 Npm-body-parser-1.20.3
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 213
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 212
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 213
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 213
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 279
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 228
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 245
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 279
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 245
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 262
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 228
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 280
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 279
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 245
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 246
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 229
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 228
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 262
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 263
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 262
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 115
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 104
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 157
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 132
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 212
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 203
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 192
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 145
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 157
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 144
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 116
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 104
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 132
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 132
LOW Log_Forging /api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/OperationController.java: 117
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 171
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 170
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 190
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 295
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 305
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 315
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 189
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 190
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 191
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 305
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 95
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 171
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 96
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 171
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 127
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 95
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 156
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 97
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 128
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 192
LOW Log_Forging /api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 190
LOW Missing_CSP_Header /ui/ui-frontend/projects/vitamui-library/src/app/modules/components/header/menu/menu.component.html: 23

Use @Checkmarx to reach out to us for assistance.

Just send a PR comment with @Checkmarx followed by a natural language request.

Examples: @Checkmarx how are you able to help me? @Checkmarx rescan this PR

@Salimdev Salimdev requested a review from marob December 2, 2025 14:11
Regzox
Regzox requested changes Dec 2, 2025
View reviewed changes
marob
marob requested changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@marob marob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a toujours un problème de détection de doublon (côté API ?).

@Salimdev Salimdev requested review from Regzox and marob December 4, 2025 16:49
marob
marob requested changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@marob marob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne vois pas ce qui a été fait pour résoudre le problème de détection de doublon.
A priori, les profils de paramétrages externes créés ont un applicationName égal à EXTERNAL_PARAMS. Or, on vérifie l'existence d'un doublon en précisant EXTERNAL_PARAM_PROFILE_APP (au lieu de EXTERNAL_PARAMS) => il faut corriger (pour la création et la modification)

@Salimdev Salimdev requested a review from marob December 5, 2025 14:26
@Salimdev Salimdev force-pushed the bug_15468 branch 2 times, most recently from 7e0585b to 75052f9 Compare December 5, 2025 15:15
marob
marob requested changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@marob marob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne pense pas qu'on puisse modifier les anciens scripts mongod : ils ne vont pas être appliqués lors des montées de version.

@bbenaissa tu confirmes ?

Par ailleurs, je ne sais pas s'il n'y a pas un problème plus profond sur la duplicité EXTERNAL_PARAMS / EXTERNAL_PARAM_PROFILE_APP

@bbenaissa
Copy link
Collaborator

bbenaissa commented Dec 8, 2025

Oui, effectivement, on ne peut pas changer les scripts de cette façon

bbenaissa
bbenaissa requested changes Dec 8, 2025
View reviewed changes
Copy link
Collaborator

@bbenaissa bbenaissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, effectivement, on ne peut pas changer les scripts de cette façon

@Salimdev
Copy link
Contributor Author

Salimdev commented Dec 8, 2025

Je ne pense pas qu'on puisse modifier les anciens scripts mongod : ils ne vont pas être appliqués lors des montées de version.

@bbenaissa tu confirmes ?

Par ailleurs, je ne sais pas s'il n'y a pas un problème plus profond sur la duplicité EXTERNAL_PARAMS / EXTERNAL_PARAM_PROFILE_APP

sinon je fais ça côté front en utilisant le parms EXTERNAL_PARAMS

@Salimdev Salimdev requested review from bbenaissa and marob December 8, 2025 11:36
marob
marob previously requested changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@marob marob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi doit-on review alors qu'il n'y a pas eu de changements ?

@Salimdev Salimdev requested a review from marob December 9, 2025 10:19
@marob marob self-requested a review December 10, 2025 17:03
@Salimdev Salimdev enabled auto-merge December 12, 2025 08:46
@Salimdev Salimdev dismissed marob’s stale review December 16, 2025 10:14

les retours traités.

@Salimdev Salimdev merged commit 4ae4c4c into develop Dec 16, 2025
12 checks passed
@Salimdev Salimdev deleted the bug_15468 branch December 16, 2025 10:14
This was referenced Jan 19, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbenaissa bbenaissa bbenaissa approved these changes

@Regzox Regzox Regzox approved these changes

@marob marob Awaiting requested review from marob

Assignees

@Salimdev Salimdev

Labels

bug Something isn't working

Projects

None yet

Milestone

IT 162

Development

Successfully merging this pull request may close these issues.

6 participants

@Salimdev @vitam-prg @bbenaissa @marob @Regzox