Skip to content

Bug #15683 : Missing red chip for objects with errors #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hazco75 merged 1 commit into from
Feb 4, 2026
Merged

Bug #15683 : Missing red chip for objects with errors #3537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions .../archive-preview/archive-unit-information-tab/archive-unit-information-tab.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,6 @@
[value]="archiveUnit()?.EndDate | dateTime: 'dd/MM/yyyy'"
/>
</div>

@if (archiveUnitErrors().length) {
<div class="text normal bold danger">{{ 'COLLECT.ARCHIVE_UNIT_PREVIEW.FIELDS.ENCOUNTERED_ERRORS' | translate | uppercase }}</div>
@for (error of archiveUnitErrors(); track $index) {
<vitamui-information-detail [error]="error" [hideEvDetData]="true"></vitamui-information-detail>
}
}
</div>

<button
Expand All @@ -69,10 +62,19 @@
<i class="vitamui-icon vitamui-icon-deposit"></i>
</button>

@if (technicalObjectsGroupErrors().length || objectsGroupErrors().length) {
<vitamui-information-bloc
[withObjectsTabLink]="true"
[decoration]="'bordered'"
(openObjectsTab)="goToObjectsTab()"
></vitamui-information-bloc>
}
<div class="gap-3 align-items-stretch">
@if (technicalObjectsGroupErrors().length || objectsGroupErrors().length) {
<vitamui-information-bloc
[withObjectsTabLink]="true"
[decoration]="'bordered'"
(openObjectsTab)="goToObjectsTab()"
></vitamui-information-bloc>
}

@if (archiveUnitErrors().length) {
<div class="text normal bold danger">{{ 'COLLECT.ARCHIVE_UNIT_PREVIEW.FIELDS.ENCOUNTERED_ERRORS' | translate | uppercase }}</div>
@for (error of archiveUnitErrors(); track $index) {
<vitamui-information-detail [error]="error" [hideEvDetData]="true"></vitamui-information-detail>
}
}
</div>
6 changes: 5 additions & 1 deletion ...-preview/collect-object-group-details-tab/collect-object-group-details-tab.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</div>

@if (technicalObjectsGroupErrors().length) {
<div class="d-flex flex-column gap-2 align-items-stretch">
<div class="d-flex flex-column gap-2 align-items-stretch mt-1">
<div class="text normal bold danger">
{{ 'COLLECT.ARCHIVE_UNIT_PREVIEW.FIELDS.ENCOUNTERED_ERRORS' | translate | uppercase }}
</div>
Expand All @@ -49,6 +49,7 @@
<vitamui-common-physical-archive-viewer
*ngIf="versionWithQualifier.qualifier === 'PhysicalMaster'"
[archive]="versionWithQualifier"
[errorMessages]="errorMessagesGot"
></vitamui-common-physical-archive-viewer>

<div
Expand All @@ -65,6 +66,9 @@
{{
('COLLECT.UNIT_OBJECT_QUALIFIER_TYPE.' + versionWithQualifier?.qualifier | translate) + ' (' + versionWithQualifier?.version + ')'
}}
@if (errorMessagesGot && errorMessagesGot[versionWithQualifier['#id']]) {
<div class="status-badge-red status-badge-mini ml-2 mt-1"></div>
}
</div>
<div class="line object-size">{{ versionWithQualifier.Size | bytes }}</div>
</div>
Expand Down
3 changes: 3 additions & 0 deletions ...es/archive-unit/components/physical-archive-viewer/physical-archive-viewer.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
</div>
<div class="line shrink object-name">
{{ ('ARCHIVE_SEARCH.UNIT_OBJECT_QUALIFIER_TYPE.' + archive.qualifier | translate) + ' (' + archive.version + ')' }}
@if (hasErrors()) {
<div class="status-badge-red status-badge-mini ml-2 mt-1"></div>
}
</div>
<div *ngIf="archive.qualifier !== 'PhysicalMaster'" class="line object-size">
{{ archive.Size | bytes }}
Expand Down
7 changes: 6 additions & 1 deletion ...ules/archive-unit/components/physical-archive-viewer/physical-archive-viewer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
*/
import { Component, Input, OnInit } from '@angular/core';
import { TranslateService } from '@ngx-translate/core';
import { ObjectQualifierType, VersionWithQualifierDto } from '../../../models';
import { ObjectQualifierType, ValidationError, VersionWithQualifierDto } from '../../../models';

interface Measurement {
name: string;
Expand Down Expand Up @@ -68,6 +68,7 @@ type MeasurementDisplayMode = 'SYMBOL' | 'NAME';
})
export class PhysicalArchiveViewerComponent implements OnInit {
@Input() archive: VersionWithQualifierDto;
@Input() errorMessages: Record<string, ValidationError[]>;

// Component configuration
private measurementDisplayMode: MeasurementDisplayMode = 'NAME';
Expand Down Expand Up @@ -111,6 +112,10 @@ export class PhysicalArchiveViewerComponent implements OnInit {
return this.displayAll || this.items.includes(displayValue.originalKey);
}

hasErrors() {
return this.errorMessages && this.errorMessages[this.archive['#id']] !== undefined;
}

private translateMeasurementDisplayValue(displayValue: DisplayValue): DisplayValue {
const { originalValue } = displayValue;

Expand Down
Loading