Draft
Conversation
|
I think you are overcomplicating things. Just let linux users build from source, they are used to it and most of the time the user repositories already have the build files there so it is simple to do too. One binary fits all clearly does not work well with how onnx is made. I already have HW acceleration on arch linux by the AUR packaging removing the shipped libonnxruntime to let it use system ones. In my case onnxruntime-opt-rocm. I think that is an acceptable step to have if the user wants to use a specific target runtime instead of the default CPU one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a similar issue to #247. Similarly, instead of statically bundling the ONNX Runtime within the application we instruct the application to look at the user's system runtime(s).
(Please note that this affects Linux only)
Pros:
Cons:
onnxruntimefor your system, and possibly (big!):rocm-hip-sdkmigraphxonnxruntime-rocmThis points to a bigger problem. A lot of these execution providers are mutually exclusive, even if we were to automate the build process for them it still falls on the end user to install the proper runtimes for their system, which may vary greatly.
Either way, I am putting it up here if any eager Linux users want to toy around with acceleration on device. Good luck, and have fun.