Skip to content

fix: helm chart service label indentation issues#768

Open
liymike wants to merge 742 commits intoProject-HAMi:masterfrom
liymike:master
Open

fix: helm chart service label indentation issues#768
liymike wants to merge 742 commits intoProject-HAMi:masterfrom
liymike:master

Conversation

@liymike
Copy link

@liymike liymike commented Jan 2, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

This pull request fixes an indentation issue in the labels section under

device-plugin/monitorservice.yaml
scheduler/service.yaml

in the Helm chart.

Which issue(s) this PR fixes:
Fixes #

Currently, the custom service labels are indented with 4 extra spaces, which is inconsistent with the other labels like below.

apiVersion: v1
kind: Service
metadata:
  name: hami-device-plugin-monitor
  labels:
    app.kubernetes.io/component: hami-device-plugin
    helm.sh/chart: hami-2.4.1
    app.kubernetes.io/name: hami
    app.kubernetes.io/instance: hami
    app.kubernetes.io/version: "2.4.1"
    app.kubernetes.io/managed-by: Helm
        monitored-by: vm

This PR corrects the indentation to align with the rest of the labels.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Xiao Zhang and others added 30 commits April 12, 2024 15:15
trivy:fix specify card type to use error
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
…node.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: wawa0210 <xiao.zhang@daocloud.io>
fix: When a node cannot bind, it should stop scheduling pods to that node
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: rongfu.leng <lenronfu@gmail.com>
Signed-off-by: rongfu.leng <lenronfu@gmail.com>
…lect-param

scheduler server add leader elect
KEP: add scheduler policy design doc and code
Signed-off-by: rongfu.leng <lenronfu@gmail.com>
shijinye and others added 28 commits December 18, 2024 15:43
Signed-off-by: jinye <jinye.shi@daocloud.io>
* update dynamic-mig document and examples

Signed-off-by: limengxuan <391013634@qq.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.4.3 to 4.5.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4.4.3...v4.5.0)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: jinye <jinye.shi@daocloud.io>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.9.0 to 6.10.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v6.9.0...v6.10.0)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…he image display problem in document; Change deployment/values.yaml before deploying dcgm-exporter.

Signed-off-by: jiangsanyin <1327212357@qq.com>
Signed-off-by: 逍遥 <dongkui0712@foxmail.com>
Signed-off-by: 逍遥 <dongkui0712@foxmail.com>
Signed-off-by: yintong.huang <yintong.huang@daocloud.io>
* update documents

Signed-off-by: limengxuan <391013634@qq.com>
Signed-off-by: elrondwong <gfengwong@gmail.com>
add-nodelock-ut

Signed-off-by: learner0810 <zhongjun.li@daocloud.io>
Signed-off-by: penguin <lihan.zhou@daocloud.io>
* update nodelock for mig instance & add document for mig monitor

Signed-off-by: limengxuan <391013634@qq.com>
* update documents for config

Signed-off-by: limengxuan <391013634@qq.com>
* Setting devicePlugin.compatWithCPUManager=true will set PASS_DEVICE_SPECS=true as an environment variable.

Signed-off-by: 张 驰 <919474320@qq.com>

* Change the parameter compatWithCPUManager for setting the PASS_DEVICE_SPECS ENV to passDeviceSpecsEnabled, and set the default value to true.

Signed-off-by: 张 驰 <919474320@qq.com>

---------

Signed-off-by: 张 驰 <919474320@qq.com>
Signed-off-by: learner0810 <zhongjun.li@daocloud.io>
…ler. (Project-HAMi#746)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: bin <bin.pan@daocloud.io>
Signed-off-by: elrondwong <gfengwong@gmail.com>
Signed-off-by: bin <bin.pan@daocloud.io>
* add star history to readme, fix typos and add more contributors and maintainers.

Signed-off-by: yangshiqi <yangshiqi1089@gmail.com>

* add spaces

Signed-off-by: yangshiqi <yangshiqi1089@gmail.com>

---------

Signed-off-by: yangshiqi <yangshiqi1089@gmail.com>
Signed-off-by: Fengyang <495160589@qq.com>
Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
Signed-off-by: yxxhero <aiopsclub@163.com>
@lengrongfu
Copy link
Member

@liymike place rebase latest code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.