feat(*): Make judge dialog non-modal to allow ranking list scrolling #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@alphagocc PTAL，十分感谢 😊 |
Member
|
我感觉这么写不对；我不知道该怎么写。 |
Contributor
Author
|
确实有道理，这个功能不是很必要。 那我 close 了？原 issue 需不需要也 close 了？ |
Member
|
先留着吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 pr 做了什么
将测评对话框改成非模态的以允许在测评的时候滚动排行榜，测评时会禁用部分控件防止用户操作。
由于 显示详情 中进行 重测 应该不需要看排行榜，所以在 details 中的 rejudge 弹出的测评对话框没有改成非模态。因为如果改了，显示详情的对话框也是模态的，没有意义，还是看不到排行榜。
fix #202