Add description metadata to model info#771
Open
RomanFenioux wants to merge 2 commits intoProject-MONAI:devfrom
Open
Add description metadata to model info#771RomanFenioux wants to merge 2 commits intoProject-MONAI:devfrom
RomanFenioux wants to merge 2 commits intoProject-MONAI:devfrom
Conversation
|
|
||
| if bundle_name_with_version not in model_info.keys(): | ||
| model_info[bundle_name_with_version] = {"checksum": "", "source": ""} | ||
| model_info[bundle_name_with_version] = {"checksum": "", "source": "", "description": ""} |
Collaborator
There was a problem hiding this comment.
Hi @RomanFenioux , this script is an old version and is not used, can you revert the changes? Thanks
Author
There was a problem hiding this comment.
Thank you, i did not know that. Should the file be deleted to avoid confusion if the script is not used anymore ?
Author
There was a problem hiding this comment.
@yiheng-wang-nv when you have time, let me know if that would be ok with you
thanks !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the description metadata to the model info file, as described in the issue #770
The rationale is to have access to more information about the available model when using https://api.github.com/repos/Project-MONAI/model-zoo/releases/tags/hosting_storage_v1
Please let me know your thought, and if this is the right approach to solve this issue.
Status
Ready