Skip to content

Project and doc changes to get ready to release 3.1 minor update #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MMelQin merged 6 commits into from
Sep 6, 2025
Merged

Project and doc changes to get ready to release 3.1 minor update #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1cbb8be
Tests show that newest MONAI v1.5 is not compatible with Holoscan SDK…
MMelQin Sep 5, 2025
5b336d1
Make Python 3.10 the min version for the code, while still at 3.9 for…
MMelQin Sep 5, 2025
f2408e9
Need set holoscan<=3.5 so that doc build with Python 3.9 may work
MMelQin Sep 6, 2025
90dcf5a
Still need to include Python3.9 for doc build, as temp fix
MMelQin Sep 6, 2025
24e8aab
One more fix
MMelQin Sep 6, 2025
59de251
last one?
MMelQin Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Set up Python 3.9
- name: Set up Python 3.10
uses: actions/setup-python@v2
with:
python-version: "3.9"
python-version: "3.10"
- name: Setup Dev Environment
run: |
pip install virtualenv
Expand Down
1 change: 1 addition & 0 deletions docs/source/release_notes/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
```{toctree}
:maxdepth: 1

v3.1.0
v3.0.0
```
## Version 2.0
Expand Down
1,032 changes: 515 additions & 517 deletions notebooks/tutorials/03_segmentation_app.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ build-backend = "setuptools.build_meta"

[tool.black]
line-length = 120
target-version = ['py38', 'py39', 'py310', 'py311', 'py312']
target-version = ['py39', 'py310', 'py311', 'py312', 'py313']
include = '\.pyi?$'
exclude = '''
(
Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
holoscan~=3.0
holoscan-cli~=3.0
holoscan<=3.5.0
holoscan-cli<=3.5.0
numpy>=1.21.6
colorama>=0.4.1
tritonclient[all]>=2.53.0
Expand Down
4 changes: 2 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ python_requires = >=3.9, <3.14
# cucim
install_requires =
numpy>=1.21.6
holoscan~=3.0
holoscan-cli~=3.0
holoscan<=3.5.0
holoscan-cli<=3.5.0
Copy link

Copilot AI Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using <=3.5.0 allows potentially incompatible patch versions above 3.5.0. Based on the PR description mentioning compatibility issues with v3.6, consider using holoscan~=3.5.0 or holoscan>=3.0,<3.6 to be more explicit about the version range and prevent issues with future 3.5.x releases.

Suggested change
holoscan-cli<=3.5.0
holoscan-cli>=3.0,<3.6

Copilot uses AI. Check for mistakes.
colorama>=0.4.1
tritonclient[all]>=2.53.0
typeguard>=3.0.0
Expand Down