Migrate to Conan 2.x #7042
Merged
Migrate to Conan 2.x #7042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiarheiFedartsou
commented
Nov 1, 2024
| popd | ||
| - name: Build example | ||
| if: ${{ matrix.NODE_PACKAGE_TESTS_ONLY != 'ON' }} | ||
| if: ${{ matrix.NODE_PACKAGE_TESTS_ONLY != 'ON' && matrix.ENABLE_CONAN != 'ON' }} |
Member
Author
There was a problem hiding this comment.
No a lot of reasons to support building libosrm example with Conan... IMO if we want to use Conan deps there instead of system ones we should make libosrm Conan package itself...
This reverts commit 62f3a67.
DennisOSRM
approved these changes
Feb 21, 2025
Collaborator
DennisOSRM
left a comment
DennisOSRM
left a comment
There was a problem hiding this comment.
Looking good. Took the liberty to fix the build after merging in latest master branch.
eliseier
pushed a commit
to wanderlog/osrm-backend
that referenced
this pull request
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conan 1.x is deprecated and it complicates things more and more...