Update PL speed limits #7079
Merged
Update PL speed limits #7079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to changes in Polish road classification on OSM, PL:trunk got deprecated. PL:expressway is being used instead: https://www.openstreetmap.org/changeset/159759046
TheDM-9
approved these changes
Dec 4, 2024
TheDM-9
reviewed
Jan 23, 2025
TheDM-9
left a comment
TheDM-9
left a comment
There was a problem hiding this comment.
The change is related to changes in tagging of dual-carriageway express roads in Poland.
|
@Dawid2849 According to this PR, I believe we should also update the taginfo.json file. Line 179 in 61464fc |
|
Yes, we should. Tagging in OSM has been changed 2 months ago and expressways are tagged source:masxpeed=PL:expressway. |
Contributor
Author
Yeah. Thanks for a reminder! |
praszuk
approved these changes
Jan 26, 2025
TheDM-9
approved these changes
Jan 26, 2025
Collaborator
|
Should both be supported? |
Contributor
Author
No. PL:trunk is deprecated and replaced by PL:expressway. |
Collaborator
|
Please merge latest master branch into your PR branch. That should fix the build failure. |
eliseier
pushed a commit
to wanderlog/osrm-backend
that referenced
this pull request
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Due to changes in Polish road classification on OSM, PL:trunk got deprecated. PL:expressway is being used instead: https://www.openstreetmap.org/changeset/159759046
Tasklist
Requirements / Relations
None