cycleway value should fall back to cycleway:both if available
#7314
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMarex
changed the title
cycleway value should fall back to cycleway:both if available
DennisOSRM
approved these changes
Jan 7, 2026
Collaborator
DennisOSRM
left a comment
DennisOSRM
left a comment
There was a problem hiding this comment.
Looking clean and simple.
Collaborator
|
Hey @TheMarex, good to see you. 👋🏼 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a fallback mechanism for the cycleway tag to use cycleway:both when cycleway is not available, addressing issue #6179.
Key Changes:
- Modified the
cyclewaytag retrieval logic to fall back tocycleway:bothifcyclewayis not present - Added comprehensive test scenarios to verify the fallback behavior works correctly for different road types
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| profiles/bicycle.lua | Implements fallback logic to use cycleway:both when cycleway tag is absent |
| features/bicycle/cycleway.feature | Adds test scenarios verifying the fallback behavior on motorway and primary roads |
| CHANGELOG.md | Documents the fix in the unreleased changes section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
👋 Have a bit of time for a few days, figured I'll help with the backlog. |
TheMarex
force-pushed
the
Nate-Wessel-patch-1
branch
from
ee4dabf to
f7d7338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes issue #6179. Thanks @Nate-Wessel!
Tasklist
Requirements / Relations
Rebased version of #6180