Remove separate osrm_guidance library, fixes #6954 #7315
Merged
+7
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
afarber
reviewed
Jan 8, 2026
TheMarex
force-pushed
the
patrick/bundle_guidance
branch
from
6bb9fc2 to
da1b412
Compare
DennisOSRM
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We avoid the problem of having to deal with link-time issues due to the circular dependencies by making
osrm_extractandosrm_guidanceone library. Historically we wanted to split guidance generation from the initial extraction process, but they are quite tangled.Tasklist
Requirements / Relations
This is a replacement for #6955