Skip to content

Conversation

@TheMarex
Copy link
Member

@TheMarex TheMarex commented Jan 9, 2026

Issue

Allow for 8 exclude combinations makes it impossible to differentiate invalid class combinations from the ones where all classes are used.

Tasklist

Requirements / Relations

Replaces #7282

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an issue where allowing 8 exclude class combinations made it impossible to differentiate invalid class combinations from cases where all classes are used. The solution reduces the maximum number of excludable classes from 8 to 7, ensuring the MSB (most significant bit) of the ClassData uint8_t type remains available to mark invalid class data. Additionally, the PR corrects a spelling typo throughout the codebase, changing INAVLID_CLASS_DATA to INVALID_CLASS_DATA.

Key Changes:

  • Reduced MAX_EXCLUDABLE_CLASSES from 8 to 7 and MAX_CLASS_INDEX from 7 to 6
  • Fixed typo: INAVLID_CLASS_DATAINVALID_CLASS_DATA across the codebase
  • Added explanatory comments about the 7-class limit

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
include/extractor/class_data.hpp Updated constants to limit max excludable classes to 7 (was 8) and max class index to 6 (was 7), corrected typo INAVLID→INVALID, added explanatory comment
include/extractor/profile_properties.hpp Corrected typo INAVLID_CLASS_DATA → INVALID_CLASS_DATA
include/util/exclude_flag.hpp Corrected typo INAVLID_CLASS_DATA → INVALID_CLASS_DATA
unit_tests/extractor/intersection_analysis_tests.cpp Corrected typo INAVLID_CLASS_DATA → INVALID_CLASS_DATA in test annotations
CHANGELOG.md Added changelog entry documenting the fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TheMarex TheMarex merged commit 29bbad5 into master Jan 9, 2026
19 checks passed
@TheMarex TheMarex deleted the patrick/fix_ex_classes branch January 9, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants