Spectator checkbox functionality

Author: ilikepizza107

Source/Core/Core/NetPlayServer.cpp

@@ -797,6 +797,47 @@ unsigned int NetPlayServer::OnData(sf::Packet& packet, Client& player)
   }
   break;
 
+  case MessageID::PadSpectator:
+  {
+    bool spectator;
+    packet >> spectator;
+
+    auto padmap = GetPadMapping();
+  
+    int player_port = -1;
+    for (int i = 0; i < (int)padmap.size(); i++)
+    {
+      if (padmap[i] == player.pid)
+      {
+        player_port = i;
+        break;
+      }
+    }
+
+    if (spectator)
+    {
+      if (player_port != -1)
+        padmap[player_port] = 0;
+    }
+    else
+    {
+      bool assigned = false;
+      for (int i = 0; i < (int)padmap.size(); i++)
+      {
+        if (padmap[i] == 0)
+        {
+          padmap[i] = player.pid;
+          assigned = true;
+          break;
+        }
+      }
+    }
+
+    this->SetPadMapping(padmap);
+  }
+  break;
+
+
   case MessageID::PadData:
   {
     // if this is pad data from the last game still being received, ignore it

Source/Core/DolphinQt/NetPlay/NetPlayDialog.cpp

@@ -405,6 +405,8 @@ void NetPlayDialog::ConnectWidgets()
   connect(m_start_button, &QPushButton::clicked, this, &NetPlayDialog::OnStart);
   connect(m_quit_button, &QPushButton::clicked, this, &NetPlayDialog::reject);
 
+  connect(m_is_spectator, &QCheckBox::toggled, this, &NetPlayDialog::IsSpectatorEnabled); 
+
   connect(m_game_button, &QPushButton::clicked, [this] {
     GameListDialog gld(m_game_list_model, this);
     SetQWidgetWindowDecorations(&gld);
@@ -493,6 +495,17 @@ void NetPlayDialog::OnChat()
   });
 }
 
+void NetPlayDialog::IsSpectatorEnabled(bool enabled)
+{
+  auto client = Settings::Instance().GetNetPlayClient();
+  if (!client)
+    return;
+  sf::Packet packet;
+  packet << static_cast<u8>(NetPlay::MessageID::PadSpectator);
+  packet << enabled;
+  client->SendAsync(std::move(packet));
+}
+
 void NetPlayDialog::OnIndexAdded(bool success, const std::string error)
 {
   DisplayMessage(success ? tr("Successfully added to the NetPlay index") :

Source/Core/DolphinQt/NetPlay/NetPlayDialog.h

@@ -81,6 +81,7 @@ class NetPlayDialog : public QDialog, public NetPlay::NetPlayUI
   bool IsRecording() override;
   bool IsMusicOff() override;
   bool IsSpectator() override;
+  void IsSpectatorEnabled(bool enabled);
   std::shared_ptr<const UICommon::GameFile>
   FindGameFile(const NetPlay::SyncIdentifier& sync_identifier,
                NetPlay::SyncIdentifierComparison* found = nullptr) override;