fix(cli): replace copydir workaround with node cp#1655
Open
KaiPrince wants to merge 1 commit intoProjectEvergreen:masterfrom
Open
fix(cli): replace copydir workaround with node cp#1655KaiPrince wants to merge 1 commit intoProjectEvergreen:masterfrom
KaiPrince wants to merge 1 commit intoProjectEvergreen:masterfrom
Conversation
better implementation of 7ba828a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better implementation of 7ba828a. Uses node's
cpfunction, which behaves like the OS' cp command. It should benefit from the parallelism used by the host OS. I don't know if this will actually make a performance difference, but it is surely much simpler.Preservation of behaviour is confirmed by the existing test: https://github.com/ProjectEvergreen/greenwood/blob/master/packages/cli/test/cases/build.default.static-asset-bundling/build.default.static-asset-bundling.spec.js
Related Issue
Issue: #823 , Follow-up to #1558
Documentation
No documentation changes.
Summary of Changes
copyDirectorywith node fs.cp.rreaddirfunction, and cleaned up imports.