fix(cli): #1575 resolve too many listeners with task queue#1656
Open
KaiPrince wants to merge 1 commit intoProjectEvergreen:masterfrom
Open
fix(cli): #1575 resolve too many listeners with task queue#1656KaiPrince wants to merge 1 commit intoProjectEvergreen:masterfrom
KaiPrince wants to merge 1 commit intoProjectEvergreen:masterfrom
Conversation
thescientist13
changed the title
thescientist13
approved these changes
Mar 19, 2026
Member
thescientist13
left a comment
thescientist13
left a comment
There was a problem hiding this comment.
Oh dang, nice. That's pretty clean. ✨
Just gave this a test in ProjectEvergreen/www.greenwoodjs.dev#249 and no more warnings!
Thanks so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The max listeners warning from #1575 is caused by a listener added for each page waiting for a free worker. Node recommends a task queue, and I have copied that implementation here. Now the number of listeners remains constant and will not increase with the number of pages.
See https://nodejs.org/api/async_context.html#using-asyncresource-for-a-worker-thread-pool.
Related Issue
Resolves #1575
Documentation
No documentation changes.
Summary of Changes