Bug/issue 820 deeply relative ESM paths in node modules not working#832
Merged
thescientist13 merged 11 commits intomasterfrom Mar 5, 2022
Merged
Conversation
2 tasks
2ea7a95 to
e94dcd0
Compare
5 tasks
0cf1fe7 to
459235d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #820
Summary of Changes
.replace('./', '')with custom functionality to better handle./vs../using @stencil/core for validationwalkModuleon packages that already provide anexportsmapTODO
../paths\) to ESM style (/)some sort of race condition it seems. Looks like the right path from the export map on Windows is being overwritten (?) later on by further calls to🔬 👀updateImportMapfrom walking the imports of a related @babel/runtime file? Was able to reproduce the same error on macOS by removing this one-off pre-check, so seems like the issue is somewhere in thereimport.meta.resolveto support import maps generation and accurate node_modules resolution when building #684importfrom a directory #907