Adjust margin in sidebar to center elements#202
Adjust margin in sidebar to center elements#202darragh4 wants to merge 1 commit intoProjectEvergreen:mainfrom
Conversation
✅ Deploy Preview for super-tapioca-5987ce ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thescientist13
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Left some feedback, in that I think we need to find a more "localized" place for this change, not a global one.
Let me know if you have any questions. 👍
|
|
||
| li { | ||
| margin: var(--size-2) 0; | ||
| margin-left: 20%; |
There was a problem hiding this comment.
This is a global style, and so changing this here is potentially going to change <li> globally, which we can see already happening in the header

I think for this kind of change, it should be happening in the styles for the table of contents component specifically
https://github.com/ProjectEvergreen/www.greenwoodjs.dev/blob/main/src/components/table-of-contents/table-of-contents.module.css
Also, for the actual value of whatever we end up going with, we should try and use open-props styles whenever possible as that is the style library we are using in this project.
I suppose we could consider seeing if this li selector is even needed here, or if it's just for markdown content, but that's probably something to work out in a standalone issue / PR
Related Issue
(#184)
Summary of Changes
Centred the ToC by adjusting the margin of the box so that it will no longer hug the left side of the box.