Update "Full Moon Mirror"

- No stated maximum number of Full Moon Counters (text implies more than 10 can be present)
- Effect to place "Infinite Fiend Mirror" should be ignition-like, not quick-like
- Replace manual method of activating Field Spells with properly Duel method
- Other bits of script modernization/polish

Author: TheRazgriz

unofficial/c511000919.lua

@@ -1,76 +1,47 @@
 --月輪鏡
 --Full Moon Mirror
 local s,id=GetID()
+local COUNTER_FULL_MOON=0x99
 function s.initial_effect(c)
-	c:EnableCounterPermit(0x99)
-	c:SetCounterLimit(0x99,10)
+	--"Full Moon Counter" enable
+	c:EnableCounterPermit(COUNTER_FULL_MOON)
 	--Activate
+	local e0=Effect.CreateEffect(c)
+	e0:SetType(EFFECT_TYPE_ACTIVATE)
+	e0:SetCode(EVENT_FREE_CHAIN)
+	c:RegisterEffect(e0)
+	--Each time a monster(s) is destroyed, add 1 "Full Moon Counter" to this card
 	local e1=Effect.CreateEffect(c)
-	e1:SetType(EFFECT_TYPE_ACTIVATE)
-	e1:SetCode(EVENT_FREE_CHAIN)
+	e1:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_CONTINUOUS)
+	e1:SetCode(EVENT_DESTROYED)
+	e1:SetRange(LOCATION_SZONE)
+	e1:SetCondition(function(e,tp,eg,ep,ev,re,r,rp)	return eg:IsExists(s.ctfilter,1,nil) end)
+	e1:SetOperation(function(e) e:GetHandler():AddCounter(COUNTER_FULL_MOON,1) end)
 	c:RegisterEffect(e1)
-	--Add counter
+	--Activate 1 "Infinite Fiend Mirror" from your hand or Deck
 	local e2=Effect.CreateEffect(c)
-	e2:SetType(EFFECT_TYPE_FIELD+EFFECT_TYPE_CONTINUOUS)
-	e2:SetProperty(EFFECT_FLAG_DELAY)
+	e2:SetDescription(aux.Stringid(id,0))
+	e2:SetType(EFFECT_TYPE_IGNITION)
 	e2:SetRange(LOCATION_SZONE)
-	e2:SetCode(EVENT_DESTROY)
-	e2:SetCondition(s.ctcon)
-	e2:SetOperation(s.ctop)
+	e2:SetCondition(function(e) return e:GetHandler():HasCounter(COUNTER_FULL_MOON,10) end)
+	e2:SetCost(Cost.SelfTribute)
+	e2:SetTarget(s.acttg)
+	e2:SetOperation(s.actop)
 	c:RegisterEffect(e2)
-	--Activate
-	local e3=Effect.CreateEffect(c)
-	e3:SetDescription(aux.Stringid(id,0))
-	e3:SetType(EFFECT_TYPE_QUICK_O)
-	e3:SetCode(EVENT_FREE_CHAIN)
-	e3:SetRange(LOCATION_SZONE)
-	e3:SetCondition(s.accon)
-	e3:SetCost(s.accost)
-	e3:SetTarget(s.actg)
-	e3:SetOperation(s.acop)
-	c:RegisterEffect(e3)
 end
-s.listed_names={100000080}
+s.counter_place_list={COUNTER_FULL_MOON}
+s.listed_names={100000080} --"Infinite Fiend Mirror"
 function s.ctfilter(c)
-	return c:IsFaceup() and c:IsLocation(LOCATION_MZONE)
-end
-function s.ctcon(e,tp,eg,ep,ev,re,r,rp)
-	return eg:IsExists(s.ctfilter,1,nil)
-end
-function s.ctop(e,tp,eg,ep,ev,re,r,rp)
-	e:GetHandler():AddCounter(0x99,1)
-end
-function s.accon(e)
-	return e:GetHandler():GetCounter(0x99)==10
+	return c:IsPreviousLocation(LOCATION_MZONE) and c:IsPreviousPosition(POS_FACEUP)
 end
-function s.accost(e,tp,eg,ep,ev,re,r,rp,chk)
-	if chk==0 then return e:GetHandler():IsAbleToGraveAsCost() end
-	Duel.SendtoGrave(e:GetHandler(),REASON_COST)
+function s.actfilter(c,tp)
+	return c:IsCode(100000080)  and c:GetActivateEffect():IsActivatable(tp,true,true)
 end
-function s.filter(c,tp)
-	return c:IsCode(100000080) and c:GetActivateEffect():IsActivatable(tp,true,true)
+function s.acttg(e,tp,eg,ep,ev,re,r,rp,chk)
+	if chk==0 then return Duel.IsExistingMatchingCard(s.actfilter,tp,LOCATION_HAND|LOCATION_DECK,0,1,nil,tp) end
 end
-function s.actg(e,tp,eg,ep,ev,re,r,rp,chk)
-	if chk==0 then return Duel.IsExistingMatchingCard(s.filter,tp,LOCATION_HAND|LOCATION_DECK,0,1,nil,tp) end
+function s.actop(e,tp,eg,ep,ev,re,r,rp)
+	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_TOFIELD)
+	local sc=Duel.SelectMatchingCard(tp,s.actfilter,tp,LOCATION_HAND|LOCATION_DECK,0,1,1,nil,tp):GetFirst()
+	Duel.ActivateFieldSpell(sc,e,tp,eg,ep,ev,re,r,rp)
 end
-function s.acop(e,tp,eg,ep,ev,re,r,rp)
-	Duel.Hint(HINT_SELECTMSG,tp,HINTMSG_EFFECT)
-	local tc=Duel.SelectMatchingCard(tp,s.filter,tp,LOCATION_HAND|LOCATION_DECK,0,1,1,nil,tp):GetFirst()
-	if tc then
-		local loc=LOCATION_SZONE
-		if (tpe&TYPE_FIELD)~=0 then
-			loc=LOCATION_FZONE
-			local fc=Duel.GetFieldCard(1-tp,LOCATION_FZONE,0)
-			if Duel.GetFlagEffect(tp,62765383)>0 then
-				if fc then Duel.Destroy(fc,REASON_RULE) end
-				of=Duel.GetFieldCard(tp,LOCATION_FZONE,0)
-				if fc and Duel.Destroy(fc,REASON_RULE)==0 then Duel.SendtoGrave(tc,REASON_RULE) end
-			else
-				Duel.GetFieldCard(tp,LOCATION_FZONE,0)
-				if fc and Duel.SendtoGrave(fc,REASON_RULE)==0 then Duel.SendtoGrave(tc,REASON_RULE) end
-			end
-		end
-		Duel.MoveToField(tc,tp,tp,loc,POS_FACEUP,true)
-		Duel.RaiseEvent(tc,EVENT_CHAIN_SOLVED,tc:GetActivateEffect(),0,tp,tp,Duel.GetCurrentChain())
-	end
-end