Improve Image and Presentation API compatibility#68
Draft
Conversation
34e2237 to
321e892
Compare
…nvasDownloadLinks
…pliance TODOs - tests for added IIIF image functions - CanvasDownloadLinks with different API versions
321e892 to
e28c96c
Compare
phil-plencner-hl
approved these changes
Jan 22, 2026
phil-plencner-hl
left a comment
There was a problem hiding this comment.
Hi @lutzhelm,
At Harvard we recently discovered were are having the same issue with version 3 iiif manifests returning inaccurate download links. I tried some of our manifests against this branch and they work correctly. Here are the ones I tried:
- https://nrs.harvard.edu/URN-3:FHCL:103496523:MANIFEST:3
- https://nrs.lib.harvard.edu/URN-3:FHCL:29400954:MANIFEST:3
- https://nrs.lib.harvard.edu/URN-3:FHCL.LOEB:25853480:MANIFEST:3
- https://nrs.harvard.edu/URN-3:FHCL:106214677:MANIFEST:3
The version 2 iiiif manifests of the same objects also continue to work correctly on this branch:
- https://nrs.harvard.edu/URN-3:FHCL:103496523:MANIFEST:2
- https://nrs.lib.harvard.edu/URN-3:FHCL:29400954:MANIFEST:2
- https://nrs.lib.harvard.edu/URN-3:FHCL.LOEB:25853480:MANIFEST:2
- https://nrs.harvard.edu/URN-3:FHCL:106214677:MANIFEST:2
From my perspective this is working and can be merged. Is that something we can do, or should we bring it up at the next Mirador Community Call?
cc: @marlo-longley @cbeer
|
I'm also wondering if there is a way to port these changes to a Mirador 3 compatible version of the plugin? We have not upgraded to 4 yet, but would like the download bug fix if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fullvs.max/w,vs.w,h) dependent on IIIF Image API versionmaxArea/maxWidth/maxHeightThe plugin also does not offer a download for every image service beyond the first; this will need to be adressed outside this PR. -> #91