Skip to content

Bug fix: viewer not scrolling to toc entry correctly#3926

Closed
fstoe wants to merge 4 commits intoProjectMirador:mainfrom
fstoe:not-scrolling-to-toc
Closed

Bug fix: viewer not scrolling to toc entry correctly#3926
fstoe wants to merge 4 commits intoProjectMirador:mainfrom
fstoe:not-scrolling-to-toc

Conversation

@fstoe
Copy link
Contributor

@fstoe fstoe commented Jul 29, 2024

I have just fixed a bug. This is related to the table of contents and the ScrollTo component.
Previously, an empty containerRef was passed to it inital, which meant that it did not scroll to the correct position in the TOC.

I used this config prop: windows: [{ manifestId: "https://iiif.ub.uni-leipzig.de/0000034390/manifest.json", canvasIndex: 330,}] for testing.

@codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.52%. Comparing base (05194d8) to head (ee5eae3).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3926   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files         313      313           
  Lines       14767    14787   +20     
  Branches     2496     2496           
=======================================
+ Hits        13958    13978   +20     
  Misses        804      804           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lutzhelm
Copy link
Contributor

It looks to me like this has already been fixed via #4077 in the meantime (also for other affected components), so this PR can be closed?

@fstoe fstoe closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants