Refactor manifesto initialization to push property localization down#4054
Merged
Refactor manifesto initialization to push property localization down#4054
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4054 +/- ##
==========================================
+ Coverage 94.52% 94.59% +0.06%
==========================================
Files 313 315 +2
Lines 14773 14756 -17
Branches 2496 2491 -5
==========================================
- Hits 13964 13958 -6
+ Misses 804 794 -10
+ Partials 5 4 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 18, 2024
654d55f to
c92dd06
Compare
…propriate label for a IIIF resource.
…ng the property values.
c605e0f to
d947941
Compare
marlo-longley
approved these changes
Jan 10, 2025
Member
marlo-longley
left a comment
There was a problem hiding this comment.
This works for me locally and in the Netlify preview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take 3.
From #3871:
From #3482:
This does the same thing as #3482, without introducing new redux state or a new selector parameter, in order to maintain API compatibility for downstream plugins. Instead, this PR:
LocaleContextand locale-context awareIIIFResourceLabelfor rendering e.g. manifest, canvas, etc labels appropriately, replacing a lot of piece-meal label functionsgetLocale/getManifestLocaleto work right... this is somewhat unfortunate, but probably less weird if we started to use hooks or more extensive use of context like Use context to pass the window id around #3661 (and a companion-window equivalent))This can be tested at https://deploy-preview-4054--mirador-dev.netlify.app/__tests__/integration/mirador/i18n.html
Fixes #3470