Conversation
marlo-longley
changed the title
marlo-longley
force-pushed
the
prop-warnings
branch
2 times, most recently
from
cc4174b to
228b23d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4072 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 313 313
Lines 14766 14769 +3
Branches 2496 2492 -4
=======================================
+ Hits 13957 13960 +3
Misses 804 804
Partials 5 5 ☔ View full report in Codecov by Sentry. |
marlo-longley
force-pushed
the
prop-warnings
branch
from
228b23d to
000de07
Compare
cbeer
reviewed
Jan 7, 2025
Comment on lines
+19
to
+21
|
|
||
| if (!accessTokenServiceId || !authServiceId) return null; | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| if (!accessTokenServiceId || !authServiceId) return null; |
authServiceId is covered later:
https://github.com/ProjectMirador/mirador/pull/4072/files#diff-dfe0ec8d6ff147fa74246b2b5bddddb923d72f4572ba8da097a5b4f991168fd9R101
I can't tell if accessTokenServiceId is critical to rendering the UI (it looks like maybe it's just used in the callbacks?)
Member
Author
There was a problem hiding this comment.
OK, re: authServiceId since it is referenced on line 24 I will keep this and remove the later check?
marlo-longley
force-pushed
the
prop-warnings
branch
from
000de07 to
1b4c943
Compare
cbeer
added a commit
that referenced
this pull request
Mar 4, 2025
cbeer
added a commit
that referenced
this pull request
Mar 4, 2025
cbeer
added a commit
that referenced
this pull request
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.