Skip to content

Add forwardRef to CompanionWindow#4074

Merged
cbeer merged 1 commit intomainfrom
fr-cw
Jan 8, 2025
Merged

Add forwardRef to CompanionWindow#4074
cbeer merged 1 commit intomainfrom
fr-cw

Conversation

@cbeer
Copy link
Collaborator

@cbeer cbeer commented Jan 7, 2025

No description provided.

@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.52%. Comparing base (5daa657) to head (5dbdfc0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4074   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files         313      313           
  Lines       14766    14766           
  Branches     2495     2496    +1     
=======================================
  Hits        13957    13957           
  Misses        804      804           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbeer cbeer marked this pull request as ready for review January 8, 2025 04:00
@marlo-longley
Copy link
Member

This looks good. I just learned that React 19 will allow for refs to be passed to functional components, and forwardRef will be deprecated. So the purpose of this PR, silencing the warning about passing refs to functional components, won't be relevant on the next version of React.

Starting in React 19, you can now access ref as a prop for function components:
https://react.dev/blog/2024/12/05/react-19#ref-as-a-prop

Anyway this PR seems important so that Mirador 4 doesn't have browser warnings. But won't be an issue down the line.

@cbeer cbeer merged commit f474ecc into main Jan 8, 2025
8 checks passed
@cbeer cbeer deleted the fr-cw branch January 8, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants