Replace JSON.parse(JSON.stringify(json)) with structuredClone#4083
Merged
jcoyne merged 1 commit intoProjectMirador:mainfrom Jan 27, 2025
Merged
Replace JSON.parse(JSON.stringify(json)) with structuredClone#4083jcoyne merged 1 commit intoProjectMirador:mainfrom
jcoyne merged 1 commit intoProjectMirador:mainfrom
Conversation
Collaborator
barmintor
commented
Jan 27, 2025
- see also https://developer.mozilla.org/en-US/docs/Web/API/Window/structuredClone
- fixes Replace JSON.parse(JSON.stringify(json)) with structuredClone #4082
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4083 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 315 315
Lines 14759 14773 +14
Branches 2490 2492 +2
=======================================
+ Hits 13961 13975 +14
Misses 794 794
Partials 4 4 ☔ View full report in Codecov by Sentry. |
jcoyne
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.