Loosen PluginComponents PropType requirement for WindowTopBarPluginMenu#4096
Merged
Loosen PluginComponents PropType requirement for WindowTopBarPluginMenu#4096
Conversation
6239946 to
b402e2f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4096 +/- ##
==========================================
- Coverage 95.05% 95.05% -0.01%
==========================================
Files 315 315
Lines 15906 15904 -2
Branches 2494 2494
==========================================
- Hits 15120 15117 -3
- Misses 782 783 +1
Partials 4 4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes an
errorscary warning found in testing plugin integration in M4 (specifically as part of sul-dlss/sul-embed#2333)This aligns this PropType with other components: for example see
mirador/src/components/BackgroundPluginArea.js
Line 13 in 6e15d9f