Move ThumbnailFactory and manifesto.js wrappers into selectors and hooks#4101
Closed
barmintor wants to merge 1 commit intoProjectMirador:mainfrom
Closed
Move ThumbnailFactory and manifesto.js wrappers into selectors and hooks#4101barmintor wants to merge 1 commit intoProjectMirador:mainfrom
barmintor wants to merge 1 commit intoProjectMirador:mainfrom
Conversation
Collaborator
barmintor
commented
Feb 12, 2025
barmintor
commented
- prepare for auth2 service parsing changes
- prevent exposing wrapper constructor changes to wrappers to broad swathes of app
- stabilize empty object/array references for input selectors
- fixes Changes to manifesto.js wrapper constructors affect code in much of application #4100
- prepare for auth2 service parsing changes - prevent exposing wrapper constructor changes to wrappers to broad swathes of app - stabilize empty object/array references for input selectors - fixes ProjectMirador#4100
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4101 +/- ##
==========================================
- Coverage 95.07% 95.07% -0.01%
==========================================
Files 317 322 +5
Lines 15973 16047 +74
Branches 2509 2515 +6
==========================================
+ Hits 15187 15257 +70
- Misses 782 786 +4
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Hmm, tiny thumbnails |
Collaborator
Author
|
Well, it's fixed. But I can't reopen this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.