Don't overwrite config.theme.components entirely#4116
Merged
marlo-longley merged 1 commit intomainfrom Feb 27, 2025
Merged
Conversation
cbeer
force-pushed
the
mirador-json-state-themes
branch
5 times, most recently
from
13b392e to
ec925d8
Compare
…s (like functions in the theme components).
cbeer
force-pushed
the
mirador-json-state-themes
branch
from
ec925d8 to
a9af928
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4116 +/- ##
=======================================
Coverage 95.08% 95.09%
=======================================
Files 317 317
Lines 16006 16012 +6
Branches 2508 2512 +4
=======================================
+ Hits 15220 15226 +6
Misses 782 782
Partials 4 4 ☔ View full report in Codecov by Sentry. |
marlo-longley
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... some of the function definitions can't be expressed in a JSON export.