Edit syntax for externalizing peer dependencies#4142
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4142 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 324 324
Lines 16147 16147
Branches 2533 2533
=======================================
Hits 15326 15326
Misses 816 816
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gerdesque
approved these changes
May 8, 2025
Collaborator
gerdesque
left a comment
There was a problem hiding this comment.
I can confirm that the build in dist/mirador.es.js does not contain the 'Incompatible React versions' error. LGTM.
Contributor
|
BTW, this is what gets hit by the function for external. Notably no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lutzhelm this was your solution, but I wanted to put it up here for the community to look at for our meeting tomorrow.
I needed to use this in combination with #4139