Skip to content

Edit syntax for externalizing peer dependencies#4142

Merged
lutzhelm merged 1 commit intomainfrom
externalize
May 22, 2025
Merged

Edit syntax for externalizing peer dependencies#4142
lutzhelm merged 1 commit intomainfrom
externalize

Conversation

@marlo-longley
Copy link
Member

@lutzhelm this was your solution, but I wanted to put it up here for the community to look at for our meeting tomorrow.
I needed to use this in combination with #4139

@codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (48ca7e0) to head (a37b056).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4142   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files         324      324           
  Lines       16147    16147           
  Branches     2533     2533           
=======================================
  Hits        15326    15326           
  Misses        816      816           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marlo-longley marlo-longley marked this pull request as ready for review April 24, 2025 19:27
@gerdesque gerdesque self-requested a review May 8, 2025 15:32
Copy link
Collaborator

@gerdesque gerdesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the build in dist/mirador.es.js does not contain the 'Incompatible React versions' error. LGTM.

@lutzhelm
Copy link
Contributor

lutzhelm commented May 9, 2025

BTW, this is what gets hit by the function for external. Notably no @emotion/styled:

@emotion/react
@mui/material
@mui/material/Accordion
@mui/material/AccordionDetails
@mui/material/AccordionSummary
@mui/material/Alert
@mui/material/AppBar
@mui/material/Autocomplete
@mui/material/Backdrop
@mui/material/Badge
@mui/material/Button
@mui/material/ButtonBase
@mui/material/Checkbox
@mui/material/Chip
@mui/material/CircularProgress
@mui/material/Collapse
@mui/material/colors
@mui/material/Dialog
@mui/material/DialogActions
@mui/material/DialogContent
@mui/material/DialogTitle
@mui/material/Divider
@mui/material/Drawer
@mui/material/Fab
@mui/material/FormControl
@mui/material/FormControlLabel
@mui/material/GlobalStyles
@mui/material/Grid
@mui/material/Grid2
@mui/material/IconButton
@mui/material/Input
@mui/material/InputAdornment
@mui/material/InputLabel
@mui/material/Link
@mui/material/List
@mui/material/ListItem
@mui/material/ListItemButton
@mui/material/ListItemIcon
@mui/material/ListItemText
@mui/material/ListSubheader
@mui/material/Menu
@mui/material/MenuItem
@mui/material/MenuList
@mui/material/Paper
@mui/material/Popover
@mui/material/Select
@mui/material/Skeleton
@mui/material/Slide
@mui/material/Slider
@mui/material/Snackbar
@mui/material/Stack
@mui/material/styles
@mui/material/SvgIcon
@mui/material/Tab
@mui/material/Tabs
@mui/material/TextField
@mui/material/Toolbar
@mui/material/Tooltip
@mui/material/Typography
@mui/material/useMediaQuery
@mui/material/utils
@mui/system
@mui/system/createStyled
@mui/system/RtlProvider
react
react-dom
react-dom/client
react-i18next
react/jsx-runtime

@lutzhelm lutzhelm merged commit 575bec4 into main May 22, 2025
11 of 12 checks passed
@lutzhelm lutzhelm deleted the externalize branch May 22, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants