Skip to content

Only enforce codecov check on pull requests#4171

Merged
jcoyne merged 1 commit intomainfrom
codecov
Sep 9, 2025
Merged

Only enforce codecov check on pull requests#4171
jcoyne merged 1 commit intomainfrom
codecov

Conversation

@marlo-longley
Copy link
Member

@marlo-longley marlo-longley commented Aug 29, 2025

This should prevent a red x that we frequently see on the main branch / repository homepage -- making the project-level check information-only.

the resulting status will pass no matter what the coverage is or what other settings are specified.

For PRs ("patches" in codecov) CI will still break if tests decrease below threshhold.

Also from my reading of the docs and using codecov's validator service, it seemed like they wanted me to rewrite the key structure, removing top level codecov:

curl --data-binary @.codecov.yml https://codecov.io/validate
Valid!

{
  "coverage": {
    "precision": 1,
    "round": "up",
    "status": {
      "project": {
        "default": {
          "informational": true
        }
      },
      "patch": {
        "default": {
          "informational": false
        }
      }
    }
  },
  "ignore": [
    "^vite.config.js.*"
  ]
}

vs.:

 curl --data-binary @.codecov.yml https://codecov.io/validate
Error at ['codecov', 'coverage']: 
unknown field

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.2%. Comparing base (feb1375) to head (957a9f9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4171     +/-   ##
=======================================
+ Coverage   95.0%   95.2%   +0.3%     
=======================================
  Files        325     325             
  Lines      16153   16153             
  Branches    2535    2547     +12     
=======================================
+ Hits       15343   15376     +33     
+ Misses       805     772     -33     
  Partials       5       5             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marlo-longley marlo-longley marked this pull request as ready for review August 29, 2025 17:55
@marlo-longley marlo-longley changed the title Only run codecov check on pull requests Only enforce codecov check on pull requests Aug 29, 2025
@jcoyne jcoyne merged commit ad3143b into main Sep 9, 2025
9 checks passed
@jcoyne jcoyne deleted the codecov branch September 9, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants