Skip to content

Revert "Restore Harvard Van Gogh image to primary fixture" #4221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enriquediaz merged 1 commit into from
Jan 29, 2026
+7 −7
Merged

Revert "Restore Harvard Van Gogh image to primary fixture" #4221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __tests__/integration/mirador/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export const PRIMARY_MANIFEST_FIXTURE_URL = 'https://iiif.harvardartmuseums.org/manifests/object/299843';
export const PRIMARY_CANVAS_FIXTURE_URL = 'https://iiif.harvardartmuseums.org/manifests/object/299843/canvas/canvas-47174892';
export const PRIMARY_MANIFEST_FIXTURE_URL = 'https://dms-data.stanford.edu/data/manifests/Parker/nb647fd0133/manifest.json';
export const PRIMARY_CANVAS_FIXTURE_URL = 'https://dms-data.stanford.edu/data/manifests/Parker/nb647fd0133/canvas/canvas-1';
2 changes: 1 addition & 1 deletion __tests__/integration/mirador/tests/minimalist.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ describe('Minimalist configuration to Mirador', () => {
setupIntegrationTestViewer(config);

it('Loads a manifest and displays it without some of the default controls', async () => {
expect(await screen.findByRole('region', { name: /Window: Self-Portrait Dedicated to Paul Gauguin/i })).toBeInTheDocument();
expect(await screen.findByRole('region', { name: /Window: Cambridge, Corpus Christi College, MS 640: Antiphoner Leaf/i })).toBeInTheDocument();

const infoButton = await screen.findByRole('tab', { name: /Information/i });
expect(infoButton).toBeInTheDocument();
Expand Down
2 changes: 1 addition & 1 deletion __tests__/integration/mirador/tests/plugin-state.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ describe('how plugins relate to state', () => {
setupIntegrationTestViewer(settings.config, settings.plugins);

it('plugin can read from state', async () => {
const text = 'Plugin:https://iiif.harvardartmuseums.org/manifests/object/299843';
const text = 'Plugin:https://dms-data.stanford.edu/data/manifests/Parker/nb647fd0133/manifest.json';
const elementWithText = await screen.findByText(text);
expect(elementWithText).toHaveTextContent(text);
});
Expand Down
2 changes: 1 addition & 1 deletion __tests__/integration/mirador/tests/viewer-config.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ describe('initialViewerConfig', () => {

describe('initialViewerConfig', () => {
it('allows initialViewerConfig to be passed', async (context) => {
expect(await screen.findByRole('region', { name: /Window: Self-Portrait Dedicated to Paul Gauguin/i })).toBeInTheDocument();
expect(await screen.findByRole('region', { name: /Window: Cambridge, Corpus Christi College, MS 640: Antiphoner Leaf/i })).toBeInTheDocument();

let viewerObject;
await waitFor(() => {
Expand Down
4 changes: 2 additions & 2 deletions __tests__/integration/mirador/tests/window-actions.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ describe('Window actions', () => {
setupIntegrationTestViewer(config);

it('Closes a Mirador window', async () => {
expect(await screen.findByRole('region', { name: /Window: Self-Portrait Dedicated to Paul Gauguin/i })).toBeInTheDocument();
expect(await screen.findByRole('region', { name: /Window: Cambridge, Corpus Christi College, MS 640: Antiphoner Leaf/i })).toBeInTheDocument();
const closeButton = screen.getByRole('button', { name: /Close window/i });
fireEvent.click(closeButton);
await waitFor(() => expect(screen.queryByRole('region', { name: /Window: Self-Portrait Dedicated to Paul Gauguin/i })).not.toBeInTheDocument());
await waitFor(() => expect(screen.queryByRole('region', { name: /Window: Cambridge, Corpus Christi College, MS 640: Antiphoner Leaf/i })).not.toBeInTheDocument());

// No windows should be present
expect(screen.queryByRole('region')).not.toBeInTheDocument();
Expand Down