Quick bug fix: subset_do does not need space kwarg #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 32.00% 40.59% +8.59%
==========================================
Files 4 4
Lines 600 606 +6
==========================================
+ Hits 192 246 +54
+ Misses 408 360 -48 ☔ View full report in Codecov by Sentry. |
anchal-physics
force-pushed
the
bug_fix
branch
from
5d134b7 to
7a3732b
Compare
space keyword argument was being used in subset_do when use_nodes was true but this requried unnecessary creation of empty dummy input when use_nodes was not true. With _parent fields in IMASdd ids, we can actually get the space object corresponding to a grid subset. So new functions have been added to get the parent objects: get_grid_ggd: gets parent grid_ggd from space or grid_subset get_space: gets corresponding space of a grid_subset from the parent. Additionally, a minor bug in deepcopy_subset has been fixed. New tests for testing subset_tools have been added as well. Since the previous 3.0.0 has a bug because of this, minor version has been rolled up.
anchal-physics
force-pushed
the
bug_fix
branch
from
7a3732b to
443eddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
space keyword argument was being used in subset_do when use_nodes was true but this requried unnecessary creation of empty dummy input when use_nodes was not true.
With _parent fields in IMASdd ids, we can actually get the space object corresponding to a grid subset. So new functions have been added to get the parent objects:
get_grid_ggd: gets parent grid_ggd from space or grid_subset
get_space: gets corresponding space of a grid_subset from the parent.
New tests for testing subset_tools have been added as well.
Since the previous 3.0.0 has a bug because of this, minor version has been rolled up.