CompatHelper: bump compat for IMASdd to 5, (keep existing compat) #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchal-physics
force-pushed
the
compathelper/new_version/2025-03-30-03-49-20-793-03778698867
branch
from
0976e62 to
5340b30
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 40.59% 41.66% +1.07%
==========================================
Files 4 4
Lines 606 612 +6
==========================================
+ Hits 246 255 +9
+ Misses 360 357 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@anchal-physics |
anchal-physics
changed the title
anchal-physics
force-pushed
the
compathelper/new_version/2025-03-30-03-49-20-793-03778698867
branch
from
ed90add to
c33bc80
Compare
Reducing arguments required with space
With use of get_space function, other functions that used to required
space as additional argument, such as get_subset_space_objects (
earlier this was called get_subset_space) and get_subset_centers, now
do not require a space object. Previous methods have been kept though
if space object is available at the calling scope.
Refactor interp by mygyoo86
Removed element type {<:all_grid_subset_prop} from all interp that work
on arrays of properties.
anchal-physics
force-pushed
the
compathelper/new_version/2025-03-30-03-49-20-793-03778698867
branch
from
c33bc80 to
ea31a61
Compare
anchal-physics
changed the title
eldond
deleted the
compathelper/new_version/2025-03-30-03-49-20-793-03778698867
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
IMASddpackage from2, 3, 4to2, 3, 4, 5.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.