-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor to use a more traditional CRUD module structure #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chriscarrollsmith
merged 18 commits into
main
from
89-use-inheritance-to-define-data-models
Apr 6, 2025
Merged
Refactor to use a more traditional CRUD module structure #104
chriscarrollsmith
merged 18 commits into
main
from
89-use-inheritance-to-define-data-models
Apr 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture' into 89-use-inheritance-to-define-data-models
- Add tests for integration of routes w/ templates - Add documentation for template variables -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 51 out of 58 changed files in this pull request and generated 1 comment.
Files not reviewed (7)
- .python-version: Language not supported
- docs/.gitignore: Language not supported
- docs/architecture.qmd: Language not supported
- docs/contributing.qmd: Language not supported
- docs/customization.qmd: Language not supported
- docs/templates.qmd: Language not supported
- index.qmd: Language not supported
Comments suppressed due to low confidence (2)
routers/user.py:22
- The parameter 'email_update_requested' is defined as a string with a default of "false"; consider using a boolean type for clarity and consistency in the template context.
email_update_requested: Optional[str] = "false",
.github/workflows/publish.yml:65
- Switching from appending to $GITHUB_ENV to writing to a custom '_environment' file may affect how environment variables propagate in the CI workflow; please confirm that this change aligns with the intended CI behavior.
echo "DB_USER=postgres" > _environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url_for
functions used in the templates point to legitimate route handlers and that templates render without errorCloses #77, closes #102, closes #89