Enforce min version of w3c-keyname to be 1.1.8#1
Enforce min version of w3c-keyname to be 1.1.8#1d4rkr00t wants to merge 1 commit intoProseMirror:masterfrom
Conversation
Version below 1.1.8 has an issue when shortcuts with the Shift key (e.g. CMD+Shift+Z) is not working properly in Chrome (maybe other browsers too). It's happening because w3c-keyname returns z (as a lowercase z) instead of Z (uppercase Z) which is breaking those shortcuts. Even though version 1.1.8 satisfies specified semver range of '^1.1.0' tooling like yarn is not updating existing yarn locks... Solution could be to manually amend yarn.lock/package-lock.json, but I think it makes total sense to just force it in a package...
I haven't really worked with yarn a lot, but is that really the main way to do this? Isn't I am not really happy about the idea of tracking the current versions of dependencies in all modules—that'd add a lot of busywork. |
|
Yeah, it seems like the only way, because for the project that has this issue it's a huge chain of dependencies e.g.: |
Well that's just terrible. What happens when you |
|
There's some discussion about this at yarnpkg/rfcs#54 , but it doesn't seem to be moving very quickly. |
Nothing... |
Version below 1.1.8 has an issue when shortcuts with the Shift key (e.g. CMD+Shift+Z) is not working properly in Chrome (maybe other browsers too). It's happening because w3c-keyname returns z (as a lowercase z) instead of Z (uppercase Z) which is breaking those shortcuts. Even though version 1.1.8 satisfies specified semver range of '^1.1.0' tooling like yarn is not updating existing yarn locks... Solution could be to manually amend yarn.lock/package-lock.json, but I think it makes total sense to just force it in a package... FIX: Upgrade `w3c-keyname` dependency to version 1.1.8 to prevent users getting stuck with a buggy version. Issue #1
|
Not too happy about the prospect of having to track transitive dependencies with new releases, but I've merged this and released it as 1.0.1, since apparently the package managers won't help here. |
|
Thank you. I'm not happy having to ask you to do that either :( But it seems like the only reliable way to enforce that right now :( |
2 participants
Version below 1.1.8 has an issue when shortcuts with the Shift key (e.g. CMD+Shift+Z) is not working properly in Chrome (maybe other browsers too).
It's happening because w3c-keyname returns z (as a lowercase z) instead of Z (uppercase Z) which is breaking those shortcuts.
Even though version 1.1.8 satisfies specified semver range of '^1.1.0' tooling like yarn is not updating existing yarn locks... Solution could be to manually amend yarn.lock/package-lock.json, but I think it makes total sense to just force it in a package...