Skip to content

feat: add GetFingerprints & GetJsonFingerprints for primary and sub keys #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sophiel-meow wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add GetFingerprints & GetJsonFingerprints for primary and sub keys #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions crypto/key.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,20 @@
return key.entity.PrimaryKey.Fingerprint
}

// GetFingerprints returns SHA-1 fingerprints of the primary key and its subkeys.
func (key *Key) GetFingerprints() (fingerprints []string) {
fingerprints = append(fingerprints, hex.EncodeToString(key.entity.PrimaryKey.Fingerprint))
for _, sub := range key.entity.Subkeys {
fingerprints = append(fingerprints, hex.EncodeToString(sub.PublicKey.Fingerprint))
}
return fingerprints
}

// GetJsonFingerprints returns the same data as JSON (for gomobile).
func (key *Key) GetJsonFingerprints() ([]byte, error) {
return json.Marshal(key.GetFingerprints())

Check failure on line 406 in crypto/key.go

View workflow job for this annotation

GitHub Actions / Lint 

File is not `gofmt`-ed with `-s` (gofmt)
}

// GetSHA256Fingerprint computes the SHA256 fingerprint of the primary key.
func (key *Key) GetSHA256Fingerprint() (fingerprint string) {
return hex.EncodeToString(getSHA256FingerprintBytes(key.entity.PrimaryKey))
Expand Down
13 changes: 13 additions & 0 deletions crypto/key_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,19 @@ func TestGetSHA256FingerprintsV4(t *testing.T) {
assert.Exactly(t, "d9ac0b857da6d2c8be985b251a9e3db31e7a1d2d832d1f07ebe838a9edce9c24", publicKey.GetSHA256Fingerprint())
}

func TestGetFingerprints(t *testing.T) {
publicKey, err := NewKeyFromArmored(readTestFile("keyring_publicKey", false))
if err != nil {
t.Fatal("Cannot unarmor key:", err)
}

allFingerprints := publicKey.GetFingerprints()

assert.Len(t, allFingerprints, 2)
assert.Exactly(t, "6e8ba229b0cccaf6962f97953eb6259edf21df24", allFingerprints[0])
assert.Exactly(t, "37e4bcf09b36e34012d10c0247dc67b5cb8267f6", allFingerprints[1])
}

func TestGetEntity(t *testing.T) {
publicKey, err := NewKeyFromArmored(readTestFile("keyring_publicKey", false))
if err != nil {
Expand Down
Loading