[Feature] RecordScanner client #1100
Merged
+915
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpitsikoulis
force-pushed
the
feat/record-scanner-client
branch
from
5114141 to
0001cae
Compare
|
@alexpitsikoulis I'll review this in a bit, basically though, as many tests as you can build proving it against a real RSS service with it, the better. |
alexpitsikoulis
force-pushed
the
feat/record-scanner-client
branch
from
0001cae to
2d1f53d
Compare
alexpitsikoulis
force-pushed
the
feat/record-scanner-client
branch
from
2d1f53d to
462eb89
Compare
There was a problem hiding this comment.
Overall really great job here Alex, the tests are good. Left some comments, but they're mostly small changes.
What we want to do prior to folding this in is test it against an actual service.
Can you write up another test file that tests it against the service? We can store all the test data related to that in envars for ci.
* Create domain separator in function in wasm * Give domain separator camelCase name * Add Record Scanner domain separator to SDK constants
… each time a client spins up
alexpitsikoulis
force-pushed
the
feat/record-scanner-client
branch
from
2621182 to
6c2d52a
Compare
alexpitsikoulis
force-pushed
the
feat/record-scanner-client
branch
from
6caffb8 to
604a207
Compare
iamalwaysuncomfortable
approved these changes
Oct 6, 2025
|
Excellent work @alexpitsikoulis this is set to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
RecordScannerclass which implements theRecordProviderinterface serves as a means of access for the Record Scanner Service.Test Plan
Unit tests on initialization of the RecordScanner as well as all of its methods, ensuring that it is making the correct HTTP requests with the correct body and headers and returning the data received from these requests as expected.
Related PRs
Upgrade to
RecordProviderinterface