[Fix] RecordPlaintext.owner() and OwnedRecord property names for private records #1186
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshacb
force-pushed
the
fix/record-plaintext-private-owner
branch
from
2e96940 to
e172f23
Compare
marshacb
force-pushed
the
fix/record-plaintext-private-owner
branch
from
e172f23 to
5defc43
Compare
…rd property names in record-provider
marshacb
force-pushed
the
fix/record-plaintext-private-owner
branch
from
5defc43 to
0df6f53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Private transfer integration tests were failing when attempting to use records created via transfer_public_to_private.
Two bugs were identified:
RecordPlaintext.owner() only handled public owner visibility:
transfer_public_to_privatestore the owner with private visibility. The owner() method returned "Record is not public" instead of extracting the address from the decrypted plaintext.Property name mismatch in NetworkRecordProvider:
recordPlaintext,programName) butOwnedRecordtype and consumers expected snake_case (record_plaintext,program_name).These issues prevented the SDK from finding and using shielded records for private transfers.
Test Plan