chore: add audit.toml to ignore known unmaintained crates#3570
chore: add audit.toml to ignore known unmaintained crates#3570vicsn merged 4 commits intoProvableHQ:stagingfrom
Conversation
|
@niklaslong could you review? I can't set reviewers it seems. |
|
I think this is a reasonable approach to take, though we should be very strict with the advisories we choose to include here. It might also be a good practice to periodically review this list. Could you also add comments to the file explaining why each advisory is ignored and perhaps link to relevant discussions? |
|
Absolutely, we should think hard about adding anything to this list. There exists a fork of |
Agreed! 👍 |
|
Looks good to me! Should we create an issue for each unmaintained dependency, so we don't forget about it? For |
@joske We should indeed just try to get rid of ansi_term, its use seems to be limited. Then we can remove that from the ignore list. Can you also add a CI job which runs cargo audit? Also for snarkVM?
And yes we can make an issue to track the situation of the paste dependency... |
7365dd7 to
9b29f7f
Compare
|
@vicsn (github) workflow added. It will fail on any warning. |
|
Apparently |
1a2cfde to
5e9ed77
Compare
|
|
|
BTW, the audit workflow will fail until the cargo update PRs are merged (#3589 and the relevant one in snarkVM). |
13fb16c to
55c3111
Compare
kaimast
left a comment
There was a problem hiding this comment.
Let's move the audit action to CircleCI, and then we can merge it.
|
I changed this PR to use CircleCI. It should be ready to merge, but I will not do it myself as I made changes. |
e776737 to
11411c9
Compare
Motivation
cargo auditcomplains thatansi_termandpastecrates are unmaintained.For
paste: As the rust community considers this 'done', we can safely ignore this warning.For
ansi_term: Crate was unmaintained for 4 years. Removed this dependency.Test Plan
no actual code changes