[Logs] Avoid transaction/solution already exists warnings
#4015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaimast
changed the title
transaction/solution already exists warningstransaction/solution already exists warnings
vicsn
previously approved these changes
Nov 19, 2025
Collaborator
|
@kaimast we may need to extend the connection deadline in the test, I've seen this one fail more often |
kaimast
force-pushed
the
log/duplicate-deployment
branch
from
f47fc22 to
387469e
Compare
vicsn
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I commonly see warnings like the following while testing:
This seems totally benign, and logging a warning may confuse users.
Proposed change
The change in this PR is very similar to #3981. The relevant functions now return
Ok(false). For a valid transaction/solution that already exist in the mempool, in which case nodes print a debug message instead of a warning.Notes
The change set is a little bigger as the channels require quite a bit of boilerplate. I hope we can eventually merge something like #3858 to simplify this.