Conversation
kaimast
force-pushed
the
feat/batch-triggers
branch
from
0f2041b to
84e73d5
Compare
kaimast
force-pushed
the
feat/batch-triggers
branch
from
40ec68f to
a51872b
Compare
kaimast
force-pushed
the
chore/update-rand
branch
from
e1694dc to
91692c7
Compare
…w block is committeed
Add a `commit_lock` (async mutex) to serialize concurrent calls to `commit_leader_certificate`. Without it, a second certificate crossing the availability threshold while the consensus callback for a prior commit is still in-flight would re-walk already-committed rounds (because `last_committed_round` hasn't been updated yet), causing duplicate subdag commits.
kaimast
force-pushed
the
feat/batch-triggers
branch
from
b20642d to
a3177c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the batch creation task, to trigger on certain events, instead of only periodically. The goal is to avoid cases where a node is not ready to propose and then waits another MIN_BATCH_DELAY (1s) instead of only for the relevant conditions. It also ensures that the batch delay timer is reset whenever the node advances.
The most important changes in this PR are in
Primary::start_handlersand the newproposal_task.rsmodule. The README details when the batch creation task is woken up.Testing
End-to-end stress tests passed:
