Conversation
bde959b to
d73fc53
Compare
b1e95e4 to
72dd553
Compare
d73fc53 to
0a6d913
Compare
ljedrz
reviewed
Oct 9, 2025
ljedrz
reviewed
Oct 9, 2025
ljedrz
reviewed
Oct 9, 2025
ljedrz
reviewed
Oct 9, 2025
Collaborator
Author
|
Thanks for the feedback! I updated all the assert messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduce the
LoggableErrortrait which enables to easily loganyhow::Errors in snarkVM. This allows to have a more uniformed error logging mechanisms across snarkOS/snarkVM.The PR's changes are also included in #2927, but the latter is already very complex and the logging changes are self-contained.
To see how
LoggableErrorcan be used, see the changes inledger/storein 71a6665.Notes