[Fix] One-off loading in epoch cache #3059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raychu86
changed the title
raychu86
changed the title
vicsn
requested changes
Dec 13, 2025
kaimast
reviewed
Dec 13, 2025
vicsn
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The existing code has a one-off issue with loading the
epoch_provers_cache. The correct behavior when nodes are operating is that the cache should be cleared when the block height reaches an epoch boundary (block_height % N::NUM_BLOCKS_PER_EPOCH == 0). However the current logic when a node loads from DB and the block state is exactly at the epoch boundary will not account for this cleared cache. This can lead to deviation from expected values in the cache.This PR fixes this by making sure the ledger has a clear cache when loading from DB and the block state starts at exactly the epoch boundary.