Skip to content

[Fix] Resolving outstanding TODOs for dynamic dispatch. #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
d0cd merged 53 commits into from
Jan 6, 2026
Merged

[Fix] Resolving outstanding TODOs for dynamic dispatch. #3065

d0cd merged 53 commits into from
Jan 6, 2026

Conversation

@d0cd
Copy link
Collaborator

@d0cd d0cd commented Dec 22, 2025

^

d0cd and others added 30 commits December 13, 2025 11:55
@d0cd
WIP redesign caller input IDs
e64f0fe
@d0cd
Complete removal of unnecessary metadata from Request
ca11128
@d0cd
Fix console requests
b383f02
@d0cd
Fix updatable count
5da5b76
@d0cd
Update counts
1ccda2e
@d0cd
Some WIP fixes
279f340
@d0cd
Fix deployment serialization and storage
08992c0
@d0cd
More cleanups
4be4d1c
@d0cd
Fix acquisition of VKs
5e08857
@d0cd
Fix spurious variables introduced in to_bits_le_with_mode
ce1b16c
@d0cd
More fixes
b0ab46e
@d0cd
Fix
971028f
@d0cd
Regen expectations
fb5845a
@d0cd
Fix
a992981
@d0cd
More fix
7301b51
@d0cd
Cleanup, test removal of public increments
de06b2f
@Antonio95
comment and clippy
a0bb74f
@Antonio95
added deserialization tests for GetDynamicRecord
ebf1619
@Antonio95
addressed ToB audit find 1
72d9c4f
@Antonio95
implemented ToB audit find 2
2dd3988
@Antonio95
added transition serialisatsion roundtrip test
e600775
@Antonio95
addressed ToB audit find 8
6e53116
@Antonio95
addressed ToB audit find 9
73bb690
@Antonio95
minor fixes, removed TODO confirmed to be unnecessary
5c79627
@d0cd
TODO cleanups
66346c9
@d0cd
Clippy
7ab9688
@d0cd
Use V2 deployment costs
de6ee72
@Antonio95
fixed inconsistent circuit metrics in two different situations
83b5a31
@Antonio95
progress with minor TODOs
df5ce17
@Antonio95
pointed two instances of record merkleization to a single piece of code
bf18d86
Antonio95 and others added 22 commits December 30, 2025 15:08
@Antonio95
removed tree from dynamic record; now computed on the fly with root s…
df6e21c 
…anity check
@Antonio95
added proving and verification to the translation example
bc11074
@Antonio95
changed Result to Option and tweaked the structure of translation_tas…
fdede96 
…ks (removed dummy keys)
@Antonio95
updated factory test
3c26516
@Antonio95
added test cases; controlled panicking zip_eq; expanded/polished tran…
6d42377 
…slation-test-cases documentation
@d0cd
Explicitly version Request and Transition
48ed660
@Antonio95
added utility function that displays the structure of a Merkle tree i…
5a21a11 
…n order to update documentation
@d0cd
Finish TODOs tagged by @d0cd
9a983fd
@d0cd
Fix request serialization
2889079
@d0cd
Resolve more TODOs
e4484fc
@d0cd
Resolve most TODOs
0c8754e
@d0cd
More fixes and add TODO
603bcca
@Antonio95
added merkle-tree printing function to clarify padding
36f74ce
@Antonio95
changed representation of empty hash and reduced minimum printing wid…
d28fa53 
…th to 1
@Antonio95
updated merkleization documentation, transferred it to DynamicFutures
d6368e4
@Antonio95
added consuption and production checks in tests
0ae27e7
@Antonio95
updated documentation on dynamic-record test cases
6f8a4fb
@Antonio95
changed GetDynamicRecord* to GetRecordDynamic* for consistency
5f02567
@d0cd
Fix cost calculations
a02d7f5
@d0cd
Serialize and deserialize transactions before adding them to the ledger
7c66915
@d0cd
Fix dynamic future resolution
6c353d3
@d0cd
Refine implementation
710a5a5
@d0cd d0cd marked this pull request as ready for review January 6, 2026 04:54
@d0cd d0cd merged commit 55811d7 into feat/dynamic-dispatch Jan 6, 2026
5 of 7 checks passed
@d0cd d0cd deleted the d0cd/dynamic-dispatch-fixes branch January 6, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d0cd @Antonio95