Draft
Conversation
Signed-off-by: ljedrz <ljedrz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an adaptation of an optimization from arkworks-rs/algebra#961. I applied an engineering methodology, and attempted to achieve some of its benefits while keeping the changes to the overall snarkVM setup to a minimum. I kept the original object and method names in order for the changes to the original implementation to be obvious, and I'm happy to adjust them as suggested.
The benchmark improvements are as follows:
Filing as a draft in case any of the applications is invalid, and to potentially adjust the names and placement of new objects.