@fed/reqwest impl parameters

[fedpre]

Motivation

Updated the remote fetching implementation to use reqwest instead of curl to avoid issues with CA certificate. This changes uses the native-tsl from reqwuest without any additional step.

Test Plan

Tested on both iOS and Android devices and the change works.

Backwards compatibility

Please review backwards compatibility. Does any functionality need to be guarded by an existing or new ConsensusVersion?

[vicsn]

Is this needed? If not can you revert (i.e. remove this line)

[fedpre]

It is and the reason is that with version 0.13 it installs by default some aws-ls-* libraries that break android. In this way, we avoid that. I tried several ways but android keeps crashing.

[vicsn]

Is it possible to make this a target-dependent exception like we have inparameters/Cargo.toml? It's hard to test on all possible platforms and we want to avoid breaking changes

[fedpre]

I will take a look if it is possible to do

[vicsn]

Update: this seems impossible: rust-lang/cargo#1197

Let's take the risk, if some client software depending on snarkVM breaks then we can figure out a resolution

[fedpre]

Ok sounds good. Let's wait on @iamalwaysuncomfortable review and then I guess we can proceed

[iamalwaysuncomfortable]

Update: this seems impossible: rust-lang/cargo#1197 Let's take the risk, if some client software depending on snarkVM breaks then we can figure out a resolution

@vicsn @fedpre It's impossible not with resolver v2, we do it on the very next line of this Cargo.toml.

[target.'cfg(target_arch="wasm32")'.dependencies.ureq]
workspace = true
features = [ "json", "gzip" ]
optional = true

[target.'cfg(not(target_arch="wasm32"))'.dependencies.ureq]
workspace = true
features = [ "json", "gzip", "rustls" ]
optional = true

Therefore this should work:

[target.'cfg(any(target_os = "android", target_os = "ios"))'.dependencies.reqwest]
version = "0.13"
default-features = false
features = [ "json", "native-tls" ]
optional = true

[target.'cfg(not(any(target_os = "android", target_os = "ios")))'.dependencies.reqwest]
version = "0.13"
default-features = false
features = [ "json" ]
optional = true

[iamalwaysuncomfortable]

@vicsn is this still mergeable?

[iamalwaysuncomfortable]

Update: this seems impossible: rust-lang/cargo#1197 Let's take the risk, if some client software depending on snarkVM breaks then we can figure out a resolution

@vicsn @fedpre It's impossible not with resolver v2, we do it on the very next line of this Cargo.toml.

[target.'cfg(target_arch="wasm32")'.dependencies.ureq]
workspace = true
features = [ "json", "gzip" ]
optional = true

[target.'cfg(not(target_arch="wasm32"))'.dependencies.ureq]
workspace = true
features = [ "json", "gzip", "rustls" ]
optional = true

Therefore this should work:

[target.'cfg(any(target_os = "android", target_os = "ios"))'.dependencies.reqwest]
version = "0.13"
default-features = false
features = [ "json", "native-tls" ]
optional = true

[target.'cfg(not(any(target_os = "android", target_os = "ios")))'.dependencies.reqwest]
version = "0.13"
default-features = false
features = [ "json" ]
optional = true

[iamalwaysuncomfortable]

Native-tls will break wasm targets and have easily the capability of breaking multiple other Rust implementations who are using rust-tls as this will enforce native-tls.

To avoid downstream breakage, the change should be this:

[target.'cfg(any(target_os = "android", target_os = "ios"))'.dependencies.reqwest]
version = "0.13"
default-features = false
features = [ "json", "native-tls" ]
optional = true

[target.'cfg(not(any(target_os = "android", target_os = "ios")))'.dependencies.reqwest]
version = "0.13"
default-features = false
features = [ "json" ]
optional = true

[iamalwaysuncomfortable]

Again native-tls would break wasm and easily break other could tls stacks as it'd enforce native-tls usage. Just target the mobile platforms specifically.

Suggested change

	[target.'cfg(all(not(target_family = "wasm"), not(target_env = "sgx")))'.dependencies.reqwest]
	version = "0.13"
	default-features = false
	features = [ "blocking", "native-tls" ]
	[target.'cfg(all(
	any(target_os = "android", target_os = "ios"),
	not(target_family = "wasm"),
	not(target_env = "sgx")
	))'.dependencies.reqwest]
	version = "0.13"
	default-features = false
	features = [ "blocking", "native-tls" ]
	[target.'cfg(all(
	not(any(target_os = "android", target_os = "ios")),
	not(target_family = "wasm"),
	not(target_env = "sgx")
	))'.dependencies.reqwest]
	version = "0.13"
	default-features = false
	features = [ "blocking" ]