[Agent] feat(pause-menu): dynamic CoreActions & CoreOptions tile integration by github-actions[bot] · Pull Request #3266 · Provenance-Emu/Provenance

github-actions · 2026-03-17T05:32:46Z

Summary

Implements dynamic tile integration for CoreActions and CoreOptions in the tile-based pause menu (depends on #3248, now merged).

CoreActionTileProvider — maps [CoreAction] → [PauseMenuTile] (orange bolt icon, ⚠︎ badge when requiresReset)
CoreOptionTileProvider — maps boolean CoreOptions → inline ON/OFF toggle tiles; appends a Core Settings tile when any options exist
PauseTileMenuView — dynamic coreTiles computed property injects core tiles after primary tiles; handles coreAction_*, coreOption_*, and coreSettings IDs in the dispatcher; shows .confirmationDialog for multi-option actions
PVEmulatorViewController+CoreOptions — adds handleCoreAction(_:) helper
Unit tests — CoreActionTileProviderTests (10 tests) + CoreOptionTileProviderTests (12 tests) using mock CoreOptional conformances

Acceptance Criteria Status

CoreActionTileProvider maps [CoreAction] → [PauseMenuTile]
CoreOptionTileProvider maps boolean CoreOptions → toggle tiles
Tiles injected into PauseTileMenuView based on active core
Reset-required actions show ⚠︎ badge
Options-requiring actions present inline confirmationDialog
No crash when core exposes no actions/options (nil/empty cases guarded)
Unit tests for both providers with mock cores

Test plan

Build for iOS simulator and tvOS simulator (no compile errors)
Launch emulator with a core that exposes CoreActions (e.g. multi-disc) — verify bolt tiles appear
Tap a requiresReset action tile — verify ⚠︎ badge visible and reset occurs
Tap a multi-option action tile — verify confirmationDialog appears
Verify boolean option tiles show ON/OFF badge and toggle on tap
Tap Core Settings tile — verify CoreOptionsDetailView sheet opens
Verify no extra tiles appear when core has no actions/options
Run swift test in PVUI: CoreActionTileProviderTests and CoreOptionTileProviderTests pass

Part of #3249
Depends on: #3248

🤖 Generated with Claude Code

github-actions · 2026-03-17T05:33:02Z

🤖 PR created. AI review starting automatically.

Copilot

Pull request overview

Adds dynamic CoreAction/CoreOption integration into the tile-based pause menu so emulator cores can surface quick actions and boolean option toggles directly in the grid UI.

Changes:

Introduces CoreActionTileProvider / CoreOptionTileProvider to map core-exposed actions/options into PauseMenuTiles.
Injects these dynamic tiles into PauseTileMenuView and dispatches taps for core actions, core option toggles, and a “Core Settings” gateway tile.
Adds unit tests for both providers and wires PVCoreBridge into the PVUIBase test target.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`PVUI/Sources/PVUIBase/PVEmulatorVC/CoreActionTileProvider.swift`	New provider(s) that convert `CoreAction` + boolean `CoreOption` into pause-menu tiles.
`PVUI/Sources/PVUIBase/PVEmulatorVC/PauseTileMenuView.swift`	Injects dynamic core tiles into the grid and handles their tap behaviors, including a confirmation dialog for multi-option actions.
`PVUI/Sources/PVUIBase/PVEmulatorVC/PVEmulatorViewController+CoreOptions.swift`	Adds a helper for forwarding `CoreAction` execution and reset behavior.
`PVUI/Tests/PVUIBaseTests/CoreActionTileProviderTests.swift`	Adds provider-focused unit tests with mock cores/options.
`PVUI/Package.swift`	Adds `PVCoreBridge` dependency to the PVUIBase tests target to compile the new tests.
`.changelog/3249.md`	Adds a changelog fragment describing the new dynamic tiles behavior.

.changelog/3249.md

+- **CoreAction Tiles** — CoreActions exposed by the active emulator core now appear as orange bolt-icon tiles in the tile-based pause menu; actions that require a reset show a ⚠︎ warning badge.
+- **CoreOption Toggle Tiles** — Boolean `CoreOption`s from the active core appear as inline ON/OFF toggle tiles directly in the pause menu grid.
+- **Core Settings Tile** — A "Core Settings" tile is automatically injected when the core exposes any options, opening the full `CoreOptionsDetailView` sheet.
+- **Multi-option Action Picker** — Core actions with multiple choices present a `confirmationDialog` inline so users can pick without leaving the pause menu.


PVUI/Sources/PVUIBase/PVEmulatorVC/PauseTileMenuView.swift

+            let currentValue = coreClass.storedValueForOption(Bool.self, key) ?? false
+            coreClass.setValue(!currentValue, forOption: option)
+


PVUI/Sources/PVUIBase/PVEmulatorVC/PauseTileMenuView.swift

+                ForEach(options, id: \.title) { opt in
+                    Button(opt.title) {
+                        pendingCoreAction = nil
+                        dismissAction(false)
+                        DispatchQueue.main.asyncAfter(deadline: .now() + 0.05) {
+                            coreWithActions.selected(action: action)
+                            self.emulatorVC.core.setPauseEmulation(false)
+                            if action.requiresReset {
+                                self.emulatorVC.core.resetEmulation()
+                            }


PVUI/Sources/PVUIBase/PVEmulatorVC/PauseTileMenuView.swift

+            let currentValue = coreClass.storedValueForOption(Bool.self, key) ?? false
+            coreClass.setValue(!currentValue, forOption: option)


PVUI/Sources/PVUIBase/PVEmulatorVC/CoreActionTileProvider.swift

+            case let .bool(display, defaultValue, _):
+                let current = coreClass.storedValueForOption(Bool.self, display.title) ?? defaultValue
+                result.append(PauseMenuTile(
+                    id: tileID(forOptionKey: display.title),
+                    icon: current ? "checkmark.square.fill" : "square",
+                    label: display.title,
+                    badge: current ? "ON" : "OFF",
+                    colorKey: current ? .green : .gray,
+                    dismissOnTap: false


PVUI/Sources/PVUIBase/PVEmulatorVC/PVEmulatorViewController+CoreOptions.swift

+    /// Triggers the given ``CoreAction`` on the active core.
+    ///
+    /// Called from ``PauseTileMenuView`` when a core-action tile is tapped.
+    /// The menu is responsible for dismissing itself; this method only
+    /// forwards the action and handles the reset side-effect.
+    public func handleCoreAction(_ action: CoreAction) {
+        guard let coreWithActions = core as? CoreActions else { return }
+        coreWithActions.selected(action: action)
+        core.setPauseEmulation(false)
+        if action.requiresReset {
+            core.resetEmulation()
+        }
+    }


JoeMatt · 2026-03-17T06:16:40Z

@claude please fix copilot review issues

github-actions · 2026-03-17T06:18:14Z

✅ Fixes Pushed — AI Re-review Queued

Completed

🚀 Agent started
📖 Read PR context + Copilot review comments
🔨 Fixed all 6 Copilot issues
📤 Pushed to agent/issue-3249

Fixes Applied

Changelog — removed trailing periods
CoreActionTileProvider — use valueForOption (MD5-aware) instead of storedValueForOption
PauseTileMenuView toggle — use valueForOption + setValue(andMD5:currentGameMD5)
Toggle re-render — @State coreOptionRefreshToken forces grid re-evaluation after toggle
Multi-option picker — passes CoreAction with selected CoreActionOption.selected = true
Duplicate logic — both dispatch paths use handleCoreAction helper

Completed: 2026-03-17

github-actions · 2026-03-17T06:23:42Z

✅ Fixes pushed — addressed all 6 Copilot review issues:

Changelog — removed trailing periods from all 4 bullet entries
CoreActionTileProvider — replaced storedValueForOption with valueForOption(option) (applies currentGameMD5 fallback + correct default handling)
PauseTileMenuView toggle — same fix for the option-toggle path + scoped setValue with currentGameMD5
Toggle re-render — added @State coreOptionRefreshToken incremented on toggle; coreTiles reads it so SwiftUI re-evaluates tile state immediately after every toggle
Multi-option picker — now builds a new CoreAction with the chosen CoreActionOption marked selected: true, so cores can distinguish which option was picked
Duplicate logic — both action-dispatch paths now call emulatorVC.handleCoreAction(_:), eliminating duplicated selected/setPause/reset inline code

…3249) - Add CoreActionTileProvider: maps CoreAction[] → PauseMenuTile[] (orange bolt tiles; ⚠︎ badge when requiresReset) - Add CoreOptionTileProvider: maps boolean CoreOptions → ON/OFF toggle tiles plus a "Core Settings" gateway tile - Inject dynamic core tiles into PauseTileMenuView (after primary tiles) - Handle coreAction_*, coreOption_*, coreSettings tile IDs in dispatcher - Show confirmationDialog for multi-option CoreActions inline - Add handleCoreAction() helper on PVEmulatorViewController - Add unit tests: CoreActionTileProviderTests, CoreOptionTileProviderTests - Add PVCoreBridge as direct dep of PVUIBaseTests for mock conformances Part of #3249 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Drop trailing periods from changelog fragment entries - Use valueForOption (MD5-aware) instead of storedValueForOption in CoreActionTileProvider and the option-toggle handler - Scope setValue calls with currentGameMD5 so per-game overrides apply - Add @State coreOptionRefreshToken + reference in coreTiles so the tile grid re-renders immediately after a toggle - Fix confirmationDialog to build a new CoreAction with the selected CoreActionOption marked selected:true so cores can distinguish picks - Switch both action dispatch paths to call handleCoreAction, removing duplicated selected/setPause/reset logic from PauseTileMenuView Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

github-actions bot requested a review from JoeMatt as a code owner March 17, 2026 05:32

github-actions bot added agent-work PR or issue being worked on by the AI agent ai-reviewing AI code review in progress labels Mar 17, 2026

github-actions bot enabled auto-merge (squash) March 17, 2026 05:32

github-actions bot mentioned this pull request Mar 17, 2026

[Feature] Dynamic CoreOptions & CoreActions tile integration #3249

Open

7 tasks

JoeMatt requested a review from Copilot March 17, 2026 05:49

Copilot started reviewing on behalf of JoeMatt March 17, 2026 05:50 View session

github-actions bot force-pushed the agent/issue-3249 branch from 824ff72 to 885eb97 Compare March 17, 2026 05:53

Copilot AI reviewed Mar 17, 2026

View reviewed changes

github-actions bot force-pushed the agent/issue-3249 branch 3 times, most recently from 84437ff to 8972150 Compare March 17, 2026 06:12

github-actions bot force-pushed the agent/issue-3249 branch from 8972150 to ce3688f Compare March 17, 2026 06:21

github-actions bot force-pushed the agent/issue-3249 branch 13 times, most recently from 390d4c9 to 15f852c Compare March 17, 2026 07:58

github-actions bot force-pushed the agent/issue-3249 branch from 15f852c to cb30442 Compare March 17, 2026 08:02

github-actions bot and others added 2 commits March 17, 2026 08:08

github-actions bot force-pushed the agent/issue-3249 branch from cb30442 to dc131a9 Compare March 17, 2026 08:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Agent] feat(pause-menu): dynamic CoreActions & CoreOptions tile integration#3266

[Agent] feat(pause-menu): dynamic CoreActions & CoreOptions tile integration#3266
github-actions[bot] wants to merge 2 commits intodevelopfrom
agent/issue-3249

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

JoeMatt commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		let currentValue = coreClass.storedValueForOption(Bool.self, key) ?? false
		coreClass.setValue(!currentValue, forOption: option)

Uh oh!

Conversation

github-actions bot commented Mar 17, 2026

Summary

Acceptance Criteria Status

Test plan

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

JoeMatt commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Fixes Pushed — AI Re-review Queued

Completed

Fixes Applied

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Mar 17, 2026 •

edited

Loading