[Agent] feat(tvOS): retrowave design language consistency wave 2

[github-actions]

Summary

Continues the retrowave design language consistency work from #3599, applying the shared RetroSettingsComponents to the next batch of settings views.

Fixed: RetroAchievementsView

• Added tvOSSettingsHorizontalPadding() (80pt) so content clears the side-menu bar on tvOS
• Replaced .buttonStyle(.card) + .retroThemedFocus with .retroFocusButtonStyle on the login and disconnect buttons

Fixed: ControllerSettingsView

• Replaced hardcoded gradient List background with RetroSettingsBackground (black + RetroGrid)
• scrollContentBackground(.hidden) so the grid shows through the list on tvOS
• .padding(.horizontal, 80) for sidebar inset on tvOS
• All tvOS section headers upgraded to RetroSettingsSectionHeader (Button Remapping, Controller Assignments, Preferred Player Slots, Preferences, Help & Guides)
• .buttonStyle(.card) + .retroThemedFocus replaced with retroFocusButtonStyle on player-assignment and preference buttons

Fixed: BackupRestoreView

• Replaced inline Color.black + RetroGrid() ZStack with RetroSettingsBackground
• tvOSSettingsHorizontalPadding() for sidebar inset on tvOS
• Backup/Restore action buttons migrated to RetroSettingsActionButton — previously had no tvOS focus styling at all; now get consistent retrowave border + built-in retroFocusButtonStyle

Fixed: BatchArtworkMatchingView

• tvOSSettingsHorizontalPadding() on filter controls and action buttons
• All .buttonStyle(.card) + .retroThemedFocus usages replaced with retroFocusButtonStyle (Find Artwork, Retry, Refresh, Clear/Apply Selected)

Remaining work (follow-up PRs)

Systems, Cores, Theme, Core Language, Core Options, RetroArch Settings, Cloud Sync, Controller Profiles, Import Saves, Rumble/Deadzone sliders — see #3598.

Part of #3598

Test plan

• RetroAchievements on tvOS: content clears side-menu bar; login/disconnect use gradient focus ring
• Controller Settings on tvOS: retrowave grid background visible; section headers are pink+uppercase; player rows and reset button use gradient focus ring
• Backup & Restore on tvOS: retrowave grid visible; Backup/Restore buttons use gradient focus ring and themed border
• Batch Artwork on tvOS: content has 80pt inset; action buttons use gradient focus ring

🤖 Generated with Claude Code

[github-actions]

Robot PR created. AI review starting automatically.

[JoeMatt]

@claude please do a self-review pass on this PR:

Verify all changed files compile (check for unresolved symbols, missing imports, type mismatches)
Check for any dead code, unused variables, or missing test coverage
Ensure multi-platform compatibility (iOS + tvOS + macOS Catalyst)
Fix all issues
Be throgough

[github-actions]

Review Complete

Self-review finished. Found and fixed 3 issues (dead code x2, alert binding anti-pattern). PR is ready for human review.

See the full review summary in the PR comments above.

[github-actions]

Self-Review Results — Fixes Applied

Issues Found & Fixed

Critical — Compile Error

• RetroAchievementsView.swift: Removed duplicate ShareSheet struct that redeclared the type already defined in ShareSheet.swift. This caused an "Invalid redeclaration of 'ShareSheet'" compile error.

Dead Code Removed

• RetroAchievementsView.swift: Removed duplicate RetroToggleStyle struct (already exists as RetroTheme.RetroToggleStyle). Updated all call sites to use RetroTheme.RetroToggleStyle().
• RetroAchievementsView.swift: Removed unused currentUser variable (fetched but never read).
• BatchArtworkMatchingView.swift: Removed unused @State private var scanlineOffset: CGFloat = 0.

Visual Bug Fixed

• BatchArtworkMatchingView.swift: Refresh button label was missing .foregroundColor(.white) — text/icon rendered with system default color against a dark gradient background, making it invisible/illegible.

Deprecated API Warnings Fixed (iOS 17)

• RetroAchievementsView.swift: Two onChange(of:) { newValue in } calls updated to two-param form { _, newValue in }.
• BackupRestoreView.swift: Two onChange(of:) { state in } calls updated to { _, state in }.

Unnecessary Annotation Removed

• RetroAchievementsView.swift: Dropped @available(iOS 15.0, tvOS 15.0, macOS 12.0, *) — minimum deployment target is already iOS 17/tvOS 17.

Files Not Modified

• ControllerSettingsView.swift: No issues found — compiles correctly on all platforms, platform guards are correct, no dead code.

Multi-Platform Check

All changes verified safe for iOS, tvOS, and macOS Catalyst. Platform guards (#if os(tvOS), #if !os(tvOS)) are intact and correct.

[JoeMatt]

@claude please do a self-review pass on this PR:

Verify all changed files compile (check for unresolved symbols, missing imports, type mismatches)
Check for any dead code, unused variables, or missing test coverage
Ensure multi-platform compatibility (iOS + tvOS + macOS Catalyst)
Fix all issues
Be throgough

[github-actions]

Self-Review Results

Reviewed all 4 changed files for compilation correctness, dead code, platform compatibility, and type safety. Found and fixed 3 issues:

Fixed Issues

1. Dead code — currentSession state variable (RetroAchievementsView.swift)
@State private var currentSession: RAUserSession? was declared but never read or written after the refactor to userProfile. Removed.

2. Dead code — moveTVOSBackup(from:) function (BackupRestoreView.swift)
This #if os(tvOS) private method was left over from a previous implementation before BackupCoordinator took over responsibility for moving the backup file. It was never called. Removed.

3. Alert binding anti-pattern (BatchArtworkMatchingView.swift)
.constant(errorMessage != nil) was used as the isPresented binding for uiKitAlert. This creates a read-only constant snapshot binding — UIKit cannot write false back through it to dismiss the alert, so tapping outside or using system dismiss would cause the alert to reappear. Fixed by adding a proper @State private var showErrorAlert = false and updating all error-setting paths to set showErrorAlert = true.

Also Simplified

initializeClient in RetroAchievementsView.swift — the function unnecessarily wrapped code in await MainActor.run { Task { ... } } when the function itself is already @MainActor async. Simplified to a flat synchronous flow (since isAuthenticated is a plain Bool property, not async).

No Issues Found

• All type references resolve correctly (RAUserSession, RAUserProfile, UserProfile, RetroAchievementsClient APIs)
• Platform guards are correct throughout (#if os(tvOS), #if !os(tvOS), #if os(iOS) || targetEnvironment(macCatalyst))
• No missing imports
• Multi-platform compatibility verified for iOS, tvOS, and macOS Catalyst
• ControllerSettingsView.swift — no issues found

[github-actions]

🤖 Merge conflict detected — Claude has been dispatched to resolve the conflicts automatically.

If conflicts cannot be resolved cleanly, the workflow will post a comment explaining what needs manual attention.

[github-actions]

✅ Rebase Conflicts Resolved

Completed

• 🚀 Agent started
• 📖 Read PR context
• 🔀 Checked out branch agent/issue-3598-wave2
• ⚔️ Resolved 1 conflict in RetroAchievementsView.swift
• 📤 Force-pushed rebased branch

Conflict Summary

File: PVUI/Sources/PVSwiftUI/Settings/RetroAchievementsView.swift

Cause: develop gained RetroSettingsToggleRow (using old RetroToggleStyle()) and a standalone RetroToggleStyle struct. The PR's self-review commit removed the duplicate RetroToggleStyle but conflicted with develop's version.

Resolution: Kept RetroSettingsToggleRow (still referenced in code), updated it to use RetroTheme.RetroToggleStyle() (canonical location), removed the redundant @available(iOS 15.0,...) annotation, fixed onChange to two-parameter form (iOS 17 API), and dropped the standalone RetroToggleStyle struct.

Completed: TIMESTAMP

[github-actions]

Rebase Conflict Resolved ✅

Resolved 1 conflict in PVUI/Sources/PVSwiftUI/Settings/RetroAchievementsView.swift and force-pushed the rebased branch.

What happened

The develop branch gained a RetroSettingsToggleRow struct (using the old RetroToggleStyle()) plus a standalone RetroToggleStyle definition. The PR's self-review commit (11a96ed49) was written before these landed in develop, so it removed the RetroToggleStyle duplicate without knowing RetroSettingsToggleRow would be present.

Resolution

• Kept RetroSettingsToggleRow (it's referenced in retroArchConfigSection)
• Updated its toggle style to RetroTheme.RetroToggleStyle() (the canonical definition)
• Removed redundant @available(iOS 15.0, tvOS 15.0, macOS 12.0, *) annotation (min target is iOS 17)
• Fixed onChange(of:) { newValue in } → { _, newValue in } (iOS 17 two-parameter form)
• Dropped the standalone RetroToggleStyle struct (duplicate of RetroTheme.RetroToggleStyle)